You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/07/08 07:09:35 UTC
[GitHub] [fineract-cn-mobile] varsvat opened a new pull request #190: App support for Couchbase in the Tellers
varsvat opened a new pull request #190:
URL: https://github.com/apache/fineract-cn-mobile/pull/190
Fixes #[FINCN-328](https://issues.apache.org/jira/browse/FINCN-328)
This PR has been created on top of PR #189 and extends offline-first support for Teller functionalities like Creating, editing and updating Tellers and also the support or task management features have been implemented, all with the Couchbase only interaction.
**Couchbase-server** :
**Sync-gateway** :
https://user-images.githubusercontent.com/53621853/124877718-f7ef6480-dfe8-11eb-8841-2fa140137238.mp4
https://user-images.githubusercontent.com/53621853/124877806-12294280-dfe9-11eb-932b-24073f6d94e0.mp4
https://user-images.githubusercontent.com/53621853/124878041-4a308580-dfe9-11eb-93f4-1124ff89842e.mp4
Please Add a Summary of what changes you have made and if possible provide links.(Optional)
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
- [x] Run the unit tests with `./gradlew check` to make sure you didn't break anything.
- [x] If you have multiple commits please combine them into one commit by squashing them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] varsvat edited a comment on pull request #190: Add offline support for all the teller functionalities using Couchbase and sync-gateway
Posted by GitBox <gi...@apache.org>.
varsvat edited a comment on pull request #190:
URL: https://github.com/apache/fineract-cn-mobile/pull/190#issuecomment-877754559
> @varsvat Please squash commits into one
shall I keep the couchbase commit separate or not? Also, have you reviewed the changes @jawidMuhammadi ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] varsvat commented on pull request #190: Add offline support for all the teller functionalities using Couchbase and sync-gateway
Posted by GitBox <gi...@apache.org>.
varsvat commented on pull request #190:
URL: https://github.com/apache/fineract-cn-mobile/pull/190#issuecomment-876194462
@jawidMuhammadi Please review this PR whenever you get time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] varsvat commented on pull request #190: Add offline support for all the teller functionalities using Couchbase and sync-gateway
Posted by GitBox <gi...@apache.org>.
varsvat commented on pull request #190:
URL: https://github.com/apache/fineract-cn-mobile/pull/190#issuecomment-878084822
I have squashed the commits. Now we should be ready to merge this PR :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] jawidMuhammadi commented on pull request #190: Add offline support for all the teller functionalities using Couchbase and sync-gateway
Posted by GitBox <gi...@apache.org>.
jawidMuhammadi commented on pull request #190:
URL: https://github.com/apache/fineract-cn-mobile/pull/190#issuecomment-877753243
@varsvat Please squash commits into one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] varsvat commented on pull request #190: Add offline support for all the teller functionalities using Couchbase and sync-gateway
Posted by GitBox <gi...@apache.org>.
varsvat commented on pull request #190:
URL: https://github.com/apache/fineract-cn-mobile/pull/190#issuecomment-877754559
> @varsvat Please squash commits into one
shall I keep the couchbase commit separate or not? Also, have you reviewed the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org