You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Zakharov (JIRA)" <ji...@apache.org> on 2006/10/27 19:45:16 UTC
[jira] Created: (HARMONY-1992) [classlib][beans] new fixes for
DefaultPersistenceDelegate failures (3)
[classlib][beans] new fixes for DefaultPersistenceDelegate failures (3)
-----------------------------------------------------------------------
Key: HARMONY-1992
URL: http://issues.apache.org/jira/browse/HARMONY-1992
Project: Harmony
Issue Type: Improvement
Components: Classlib
Environment: winXP
Reporter: Alexei Zakharov
The attached patch fixes the following tests from the org.apache.harmony.beans.tests.java.beans.DefaultPersistenceDelegateTest class:
testInitialize_NormalBeanInfo
testInitialize_SameInstance
testInitialize_TransientProperty
testInitialize_NullEncoder
These tests were refactored. All references to CallVerificationStack class were removed (as it was decided in the mailing list) and replaced with much more lightweight technique. During enabling of these tests I found that RI uses a bit different model for DefaultPersistenceDelegate#initialize() (and probably for other methods) and stores a lot of extra statements to the output stream. From the spec point of view these statements are not really required. I've decided to keep the current model for now and just hack the tests to satisfy both models (ours and RI's). However, if during enabling of some real applications it turns out that we need so follow the RI's model I promise to get back to this.
testInitialize_NotRegularGetter
Deleted since the logic is the same with the testInitialize_NormalBeanInfo test
testInitizalize_Normal
The test was reworked, extra test logic was added.
Now all tests pass on Harmony. So we can remove DefaultPersistenceDelegateTest from exclude list. BTW, there are still two valid failures on RI.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1992) [classlib][beans] new fixes for
DefaultPersistenceDelegate failures (3)
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1992?page=all ]
Alexei Zakharov resolved HARMONY-1992.
--------------------------------------
Resolution: Fixed
> [classlib][beans] new fixes for DefaultPersistenceDelegate failures (3)
> -----------------------------------------------------------------------
>
> Key: HARMONY-1992
> URL: http://issues.apache.org/jira/browse/HARMONY-1992
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Alexei Zakharov
> Attachments: HY1992-DefaultPersistenceDelegate.patch, HY1992-DefaultPersistenceDelegateTest.patch
>
>
> The attached patch fixes the following tests from the org.apache.harmony.beans.tests.java.beans.DefaultPersistenceDelegateTest class:
> testInitialize_NormalBeanInfo
> testInitialize_SameInstance
> testInitialize_TransientProperty
> testInitialize_NullEncoder
> These tests were refactored. All references to CallVerificationStack class were removed (as it was decided in the mailing list) and replaced with much more lightweight technique. During enabling of these tests I found that RI uses a bit different model for DefaultPersistenceDelegate#initialize() (and probably for other methods) and stores a lot of extra statements to the output stream. From the spec point of view these statements are not really required. I've decided to keep the current model for now and just hack the tests to satisfy both models (ours and RI's). However, if during enabling of some real applications it turns out that we need so follow the RI's model I promise to get back to this.
> testInitialize_NotRegularGetter
> Deleted since the logic is the same with the testInitialize_NormalBeanInfo test
> testInitizalize_Normal
> The test was reworked, extra test logic was added.
> Now all tests pass on Harmony. So we can remove DefaultPersistenceDelegateTest from exclude list. BTW, there are still two valid failures on RI.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1992) [classlib][beans] new fixes for
DefaultPersistenceDelegate failures (3)
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1992?page=all ]
Alexei Zakharov updated HARMONY-1992:
-------------------------------------
Attachment: HY1992-DefaultPersistenceDelegateTest.patch
> [classlib][beans] new fixes for DefaultPersistenceDelegate failures (3)
> -----------------------------------------------------------------------
>
> Key: HARMONY-1992
> URL: http://issues.apache.org/jira/browse/HARMONY-1992
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Attachments: HY1992-DefaultPersistenceDelegateTest.patch
>
>
> The attached patch fixes the following tests from the org.apache.harmony.beans.tests.java.beans.DefaultPersistenceDelegateTest class:
> testInitialize_NormalBeanInfo
> testInitialize_SameInstance
> testInitialize_TransientProperty
> testInitialize_NullEncoder
> These tests were refactored. All references to CallVerificationStack class were removed (as it was decided in the mailing list) and replaced with much more lightweight technique. During enabling of these tests I found that RI uses a bit different model for DefaultPersistenceDelegate#initialize() (and probably for other methods) and stores a lot of extra statements to the output stream. From the spec point of view these statements are not really required. I've decided to keep the current model for now and just hack the tests to satisfy both models (ours and RI's). However, if during enabling of some real applications it turns out that we need so follow the RI's model I promise to get back to this.
> testInitialize_NotRegularGetter
> Deleted since the logic is the same with the testInitialize_NormalBeanInfo test
> testInitizalize_Normal
> The test was reworked, extra test logic was added.
> Now all tests pass on Harmony. So we can remove DefaultPersistenceDelegateTest from exclude list. BTW, there are still two valid failures on RI.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1992) [classlib][beans] new fixes for
DefaultPersistenceDelegate failures (3)
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1992?page=comments#action_12447854 ]
Alexei Zakharov commented on HARMONY-1992:
------------------------------------------
Patches were applied to the revision r472158. MockFoo and MockFooLabel classes were also patched. They were missed in the original patch - shame on me.
> [classlib][beans] new fixes for DefaultPersistenceDelegate failures (3)
> -----------------------------------------------------------------------
>
> Key: HARMONY-1992
> URL: http://issues.apache.org/jira/browse/HARMONY-1992
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Alexei Zakharov
> Attachments: HY1992-DefaultPersistenceDelegate.patch, HY1992-DefaultPersistenceDelegateTest.patch
>
>
> The attached patch fixes the following tests from the org.apache.harmony.beans.tests.java.beans.DefaultPersistenceDelegateTest class:
> testInitialize_NormalBeanInfo
> testInitialize_SameInstance
> testInitialize_TransientProperty
> testInitialize_NullEncoder
> These tests were refactored. All references to CallVerificationStack class were removed (as it was decided in the mailing list) and replaced with much more lightweight technique. During enabling of these tests I found that RI uses a bit different model for DefaultPersistenceDelegate#initialize() (and probably for other methods) and stores a lot of extra statements to the output stream. From the spec point of view these statements are not really required. I've decided to keep the current model for now and just hack the tests to satisfy both models (ours and RI's). However, if during enabling of some real applications it turns out that we need so follow the RI's model I promise to get back to this.
> testInitialize_NotRegularGetter
> Deleted since the logic is the same with the testInitialize_NormalBeanInfo test
> testInitizalize_Normal
> The test was reworked, extra test logic was added.
> Now all tests pass on Harmony. So we can remove DefaultPersistenceDelegateTest from exclude list. BTW, there are still two valid failures on RI.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1992) [classlib][beans] new fixes for
DefaultPersistenceDelegate failures (3)
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1992?page=comments#action_12447868 ]
Alexei Zakharov commented on HARMONY-1992:
------------------------------------------
When I remove DefaultPersistenceDelegate test from the exclude list another beans test - IntrospectionExceptionTest - starts to hang on the DRLVM DEBUG build. So I'm preserving the current exclude list state until the DRLVM issue is fixed.
> [classlib][beans] new fixes for DefaultPersistenceDelegate failures (3)
> -----------------------------------------------------------------------
>
> Key: HARMONY-1992
> URL: http://issues.apache.org/jira/browse/HARMONY-1992
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Alexei Zakharov
> Attachments: HY1992-DefaultPersistenceDelegate.patch, HY1992-DefaultPersistenceDelegateTest.patch
>
>
> The attached patch fixes the following tests from the org.apache.harmony.beans.tests.java.beans.DefaultPersistenceDelegateTest class:
> testInitialize_NormalBeanInfo
> testInitialize_SameInstance
> testInitialize_TransientProperty
> testInitialize_NullEncoder
> These tests were refactored. All references to CallVerificationStack class were removed (as it was decided in the mailing list) and replaced with much more lightweight technique. During enabling of these tests I found that RI uses a bit different model for DefaultPersistenceDelegate#initialize() (and probably for other methods) and stores a lot of extra statements to the output stream. From the spec point of view these statements are not really required. I've decided to keep the current model for now and just hack the tests to satisfy both models (ours and RI's). However, if during enabling of some real applications it turns out that we need so follow the RI's model I promise to get back to this.
> testInitialize_NotRegularGetter
> Deleted since the logic is the same with the testInitialize_NormalBeanInfo test
> testInitizalize_Normal
> The test was reworked, extra test logic was added.
> Now all tests pass on Harmony. So we can remove DefaultPersistenceDelegateTest from exclude list. BTW, there are still two valid failures on RI.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1992) [classlib][beans] new fixes for
DefaultPersistenceDelegate failures (3)
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1992?page=all ]
Alexei Zakharov updated HARMONY-1992:
-------------------------------------
Attachment: HY1992-DefaultPersistenceDelegate.patch
> [classlib][beans] new fixes for DefaultPersistenceDelegate failures (3)
> -----------------------------------------------------------------------
>
> Key: HARMONY-1992
> URL: http://issues.apache.org/jira/browse/HARMONY-1992
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Attachments: HY1992-DefaultPersistenceDelegate.patch, HY1992-DefaultPersistenceDelegateTest.patch
>
>
> The attached patch fixes the following tests from the org.apache.harmony.beans.tests.java.beans.DefaultPersistenceDelegateTest class:
> testInitialize_NormalBeanInfo
> testInitialize_SameInstance
> testInitialize_TransientProperty
> testInitialize_NullEncoder
> These tests were refactored. All references to CallVerificationStack class were removed (as it was decided in the mailing list) and replaced with much more lightweight technique. During enabling of these tests I found that RI uses a bit different model for DefaultPersistenceDelegate#initialize() (and probably for other methods) and stores a lot of extra statements to the output stream. From the spec point of view these statements are not really required. I've decided to keep the current model for now and just hack the tests to satisfy both models (ours and RI's). However, if during enabling of some real applications it turns out that we need so follow the RI's model I promise to get back to this.
> testInitialize_NotRegularGetter
> Deleted since the logic is the same with the testInitialize_NormalBeanInfo test
> testInitizalize_Normal
> The test was reworked, extra test logic was added.
> Now all tests pass on Harmony. So we can remove DefaultPersistenceDelegateTest from exclude list. BTW, there are still two valid failures on RI.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1992) [classlib][beans] new fixes for
DefaultPersistenceDelegate failures (3)
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1992?page=all ]
Alexei Zakharov reassigned HARMONY-1992:
----------------------------------------
Assignee: Alexei Zakharov
> [classlib][beans] new fixes for DefaultPersistenceDelegate failures (3)
> -----------------------------------------------------------------------
>
> Key: HARMONY-1992
> URL: http://issues.apache.org/jira/browse/HARMONY-1992
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Alexei Zakharov
> Attachments: HY1992-DefaultPersistenceDelegate.patch, HY1992-DefaultPersistenceDelegateTest.patch
>
>
> The attached patch fixes the following tests from the org.apache.harmony.beans.tests.java.beans.DefaultPersistenceDelegateTest class:
> testInitialize_NormalBeanInfo
> testInitialize_SameInstance
> testInitialize_TransientProperty
> testInitialize_NullEncoder
> These tests were refactored. All references to CallVerificationStack class were removed (as it was decided in the mailing list) and replaced with much more lightweight technique. During enabling of these tests I found that RI uses a bit different model for DefaultPersistenceDelegate#initialize() (and probably for other methods) and stores a lot of extra statements to the output stream. From the spec point of view these statements are not really required. I've decided to keep the current model for now and just hack the tests to satisfy both models (ours and RI's). However, if during enabling of some real applications it turns out that we need so follow the RI's model I promise to get back to this.
> testInitialize_NotRegularGetter
> Deleted since the logic is the same with the testInitialize_NormalBeanInfo test
> testInitizalize_Normal
> The test was reworked, extra test logic was added.
> Now all tests pass on Harmony. So we can remove DefaultPersistenceDelegateTest from exclude list. BTW, there are still two valid failures on RI.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira