You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@mynewt.apache.org by "Peter Snyder (JIRA)" <ji...@apache.org> on 2016/09/20 23:38:21 UTC

[jira] [Comment Edited] (MYNEWT-380) Only one fcb log supported

    [ https://issues.apache.org/jira/browse/MYNEWT-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508096#comment-15508096 ] 

Peter Snyder edited comment on MYNEWT-380 at 9/20/16 11:37 PM:
---------------------------------------------------------------

This was fixed along with fix to MYNEWT-262 which came along with pull request #104 into the develop branch (https://github.com/apache/incubator-mynewt-core/pull/104/commits). The change was to have applications separately allocate and initialize a log resource and then register it (via log_register()). In this manner, separate fcb logs could be used.

This was tested by modifying the slinky app to allocate a separate fcb_log and register it by sharing the reboot_log fcb. A log entry was added and listed using newtmgr.


was (Author: peterfs):
This was fixed along with fix to MYNEWT-262 which came along with pull request #104 into the develop branch (https://github.com/apache/incubator-mynewt-core/pull/104/commits). The change was to have applications separately allocate and initialize a log resource and then register it (via log_register()). In this manner, separate fcb logs could be used.

This was tested by modifying the slinky app to allocate a separate fcb_log and register it by sharing the reboot_log fcb. A log entry was added a printed out using newtmgr.

> Only one fcb log supported
> --------------------------
>
>                 Key: MYNEWT-380
>                 URL: https://issues.apache.org/jira/browse/MYNEWT-380
>             Project: Mynewt
>          Issue Type: Bug
>            Reporter: Christopher Collins
>            Assignee: Peter Snyder
>             Fix For: v1_0_0_beta1
>
>
> sys/log/src/log_fcb.c contains a global fcb_log struct that is used for the reboot log.  An application may want to use several FCB logs, which is currently not possible.
> A possible solution is to change log_fcb_handler_init() as follows:
> From:
> {code}
> int
> log_fcb_handler_init(struct log_handler *handler, struct fcb *fcb, uint8_t entries)
> {code}
> To:
> {code}
> int
> log_fcb_handler_init(struct log_handler *handler, struct fcb_log *fcb_log, uint8_t entries)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)