[GitHub] cloud-fan commented on issue #23882: [SPARK-26979][PySpark][WIP] Add missing column name support for some SQL functions

[GitBox <gi...@apache.org>]

cloud-fan commented on issue #23882: [SPARK-26979][PySpark][WIP] Add missing column name support for some SQL functions
URL: https://github.com/apache/spark/pull/23882#issuecomment-467058289
 
 
   I haven't read through the entire thread, just want to provide some background.
   
   At the beginning, having a string version of the function was considered as good for UX. However, when we add more and more functions, problems occur.
   
   When a function takes a column, the column can be in 3 types:
   1. a `Column`
   2. a `String`
   3. a java type of the column literal, like `double`, `int`, etc.
   
   2 and 3 may conflict if it's a string column.
   
   I think a reasonable rule is giving up 3. Up to my experience, passing a column name string is more common than passing a literal of the column.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org