You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Jacques Nadeau <ja...@gmail.com> on 2015/04/01 07:12:27 UTC
Re: Review Request 32165: DRILL-1833: Avoid storing view info in
PStore cache
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32165/#review78471
-----------------------------------------------------------
Ship it!
One little comment, otherwise lgtm.
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
<https://reviews.apache.org/r/32165/#comment127237>
Can we be more specific in this warning.
- Jacques Nadeau
On March 30, 2015, 9:43 p.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32165/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 9:43 p.m.)
>
>
> Review request for drill and Jacques Nadeau.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Please see DRILL-1833 for details.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/DotDrillFile.java 6a5934b
> exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/DotDrillType.java 74b71e7
> exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/DotDrillUtil.java cef4359
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java 7a1f61e
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java 7c8d9b3
>
> Diff: https://reviews.apache.org/r/32165/diff/
>
>
> Testing
> -------
>
> Existing tests have passed.
>
>
> Thanks,
>
> Venki Korukanti
>
>