[GitHub] [guacamole-server] mike-jumper commented on pull request #317: GUACAMOLE-1186: Maintain the clipboard content of the remote server.

[GitBox <gi...@apache.org>]

mike-jumper commented on pull request #317:
URL: https://github.com/apache/guacamole-server/pull/317#issuecomment-750107665


   I'm not against altering things such that things work cleanly even if you attempt to copy data that Guacamole itself does not currently handle, but I don't think this is the correct approach. This will remove the ability to clear the clipboard, and looks like it will result in requesting the RDP server send us data that we will simply drop (it would be better to just not request it).
   
   You mentioned:
   
   > Because we need to reset the local clipboard. That's, to get the opportunity to reset the local clipboard when users copy any data other than text.
   
   There is no need to request the RDP server send us _anything_ in order to do that. If you want to reset the local clipboard, you can just reset it. That said, I don't think we should be resetting the local clipboard as a means of achieving what you're trying to achieve.
   
   I'd think the solution to the difficulty you're encountering with images would be:
   
   * Don't clear the clipboard if unknown data is received (behave as if nothing has changed)
   * Don't send the local clipboard to the RDP server unless it's changed locally.
   
   I believe the server is already doing the former, and the client _should_ actually already be doing the latter. If either of those are not the case, then perhaps correcting that would correct this cleanly?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org