You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/02/11 23:27:38 UTC
[GitHub] [httpcomponents-client] careylam opened a new pull request #285: Fix the issues causing Kerberos/SPNego to fail
careylam opened a new pull request #285:
URL: https://github.com/apache/httpcomponents-client/pull/285
1. At the beginning of the negotiate, no token is defined in "WWW-Authenticate: Negotiate".
2. Kerberos expects HTTP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] careylam closed pull request #285: Fix the issues causing Kerberos/SPNego to fail
Posted by GitBox <gi...@apache.org>.
careylam closed pull request #285:
URL: https://github.com/apache/httpcomponents-client/pull/285
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on a change in pull request #285: Fix the issues causing Kerberos/SPNego to fail
Posted by GitBox <gi...@apache.org>.
ok2c commented on a change in pull request #285:
URL: https://github.com/apache/httpcomponents-client/pull/285#discussion_r578201266
##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/GGSSchemeBase.java
##########
@@ -133,9 +131,9 @@ protected GSSManager getManager() {
* @since 4.4
*/
protected byte[] generateGSSToken(
- final byte[] input, final Oid oid, final String serviceName, final String authServer) throws GSSException {
+ final byte[] input, final Oid oid, final String authServer) throws GSSException {
Review comment:
@careylam Could you please keep the original method signature for the backward compatibility sake?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org