You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by amandamoran <gi...@git.apache.org> on 2016/03/22 01:33:34 UTC
[GitHub] incubator-trafodion pull request: [[TRAFODION 1903 ]] Removing TRA...
GitHub user amandamoran opened a pull request:
https://github.com/apache/incubator-trafodion/pull/399
[[TRAFODION 1903 ]] Removing TRAFODION VERSION and other clean up
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amandamoran/incubator-trafodion installbugfixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/399.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #399
----
commit 93728159a11e7a0e274740b41dd38a823fd50e10
Author: Amanda Moran <am...@apache.com>
Date: 2016-03-22T00:31:45Z
[[TRAFODION 1903 ]] Removing TRAFODION VERSION and other clean up
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [[TRAFODION 1903 ]] Removing TRA...
Posted by arvind-narain <gi...@git.apache.org>.
Github user arvind-narain commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/399#discussion_r57029615
--- Diff: install/installer/rest_installer ---
@@ -108,13 +108,6 @@ mv $MY_SQROOT/sqenvcom.temp $MY_SQROOT/sqenvcom.sh
cd $REST_DIR/conf
echo "***INFO: modifying $REST_DIR/conf/rest-site.xml"
-# get zookeeper quorum
-
-lineNumber=$(grep -n "zookeeper\.quorum" /etc/hbase/conf/hbase-site.xml | sed 's/\:.*//')
-lineNumber=$((lineNumber+1))
-
-ZOOKEEPER_NODES=`sed "$lineNumber!d" /etc/hbase/conf/hbase-site.xml | sed 's/\/value.*//' | sed 's/.*>//' | sed 's/.$//'`
-
# add zookeeper quorum property to end of configuration
rm rest-site.temp 2>/dev/null
cat rest-site.xml | sed -e "s@</configuration>@ <property>\n <name>rest.zookeeper.quorum</name>\n <value>$ZOOKEEPER_NODES</value>\n </property>\n </configuration>@" > rest-site.temp
--- End diff --
Should we source in the traf config file ( as done in dcs_installer ) to pickup $ZOOKEEPER_NODES ? or is it available at this point ?
source $TRAF_CONFIG
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [[TRAFODION 1903 ]] Removing TRA...
Posted by amandamoran <gi...@git.apache.org>.
Github user amandamoran commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/399#discussion_r57246433
--- Diff: install/installer/rest_installer ---
@@ -108,13 +108,6 @@ mv $MY_SQROOT/sqenvcom.temp $MY_SQROOT/sqenvcom.sh
cd $REST_DIR/conf
echo "***INFO: modifying $REST_DIR/conf/rest-site.xml"
-# get zookeeper quorum
-
-lineNumber=$(grep -n "zookeeper\.quorum" /etc/hbase/conf/hbase-site.xml | sed 's/\:.*//')
-lineNumber=$((lineNumber+1))
-
-ZOOKEEPER_NODES=`sed "$lineNumber!d" /etc/hbase/conf/hbase-site.xml | sed 's/\/value.*//' | sed 's/.*>//' | sed 's/.$//'`
-
# add zookeeper quorum property to end of configuration
rm rest-site.temp 2>/dev/null
cat rest-site.xml | sed -e "s@</configuration>@ <property>\n <name>rest.zookeeper.quorum</name>\n <value>$ZOOKEEPER_NODES</value>\n </property>\n </configuration>@" > rest-site.temp
--- End diff --
Added this! Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [[TRAFODION 1903 ]] Removing TRA...
Posted by amandamoran <gi...@git.apache.org>.
Github user amandamoran commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/399#discussion_r57037624
--- Diff: install/installer/rest_installer ---
@@ -108,13 +108,6 @@ mv $MY_SQROOT/sqenvcom.temp $MY_SQROOT/sqenvcom.sh
cd $REST_DIR/conf
echo "***INFO: modifying $REST_DIR/conf/rest-site.xml"
-# get zookeeper quorum
-
-lineNumber=$(grep -n "zookeeper\.quorum" /etc/hbase/conf/hbase-site.xml | sed 's/\:.*//')
-lineNumber=$((lineNumber+1))
-
-ZOOKEEPER_NODES=`sed "$lineNumber!d" /etc/hbase/conf/hbase-site.xml | sed 's/\/value.*//' | sed 's/.*>//' | sed 's/.$//'`
-
# add zookeeper quorum property to end of configuration
rm rest-site.temp 2>/dev/null
cat rest-site.xml | sed -e "s@</configuration>@ <property>\n <name>rest.zookeeper.quorum</name>\n <value>$ZOOKEEPER_NODES</value>\n </property>\n </configuration>@" > rest-site.temp
--- End diff --
I think it would be available, but probably a good idea to source it in.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [[TRAFODION 1903 ]] Removing TRA...
Posted by amandamoran <gi...@git.apache.org>.
Github user amandamoran closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/399
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [[TRAFODION 1903 ]] Removing TRA...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/399
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [[TRAFODION 1903 ]] Removing TRA...
Posted by amandamoran <gi...@git.apache.org>.
GitHub user amandamoran reopened a pull request:
https://github.com/apache/incubator-trafodion/pull/399
[[TRAFODION 1903 ]] Removing TRAFODION VERSION and other clean up
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amandamoran/incubator-trafodion installbugfixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/399.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #399
----
commit 93728159a11e7a0e274740b41dd38a823fd50e10
Author: Amanda Moran <am...@apache.com>
Date: 2016-03-22T00:31:45Z
[[TRAFODION 1903 ]] Removing TRAFODION VERSION and other clean up
commit cf700b93b328d349fe3c42025034d91524d189e5
Author: Amanda Moran <am...@apache.com>
Date: 2016-03-22T00:37:18Z
Removing debugging flags
commit 3159f4c6dc1c232c18c5b23014855578fd625e29
Author: Amanda Moran <am...@apache.com>
Date: 2016-03-23T21:55:24Z
Fix for HDP
commit cb4367b3b98a0a8c568cd6037ce8ab6daf54f557
Author: Amanda Moran <am...@apache.com>
Date: 2016-03-23T22:02:11Z
Sourcing in config file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---