You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/01/13 22:31:14 UTC
Re: Review Request 16825: Add decommission support for TaskTracker and
modify support for DataNode to match
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16825/#review31656
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
- Line 247-254: Can this setting host level params be abstracted out, I presume this happens at few other places?
- Line 589: Minor typo in log message.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
- Line 81: READ_TIMEOUT - Can we append a SECONDS/MINUTES to the constant name?
Rest of the patch look good to ship.
- Sid Wagle
On Jan. 13, 2014, 6:20 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16825/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 6:20 p.m.)
>
>
> Review request for Ambari, Mahadev Konar and Sid Wagle.
>
>
> Bugs: AMBARI-4270
> https://issues.apache.org/jira/browse/AMBARI-4270
>
>
> Repository: ambari
>
>
> Description
> -------
>
> See descriptions in JIRA.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/resource_management/libraries/script/script.py b8c9d83
> ambari-server/src/main/java/org/apache/ambari/server/Role.java f579062
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 264e5d7
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java fb7ac0c
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 6165f59
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperImpl.java 8c5d733
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java ca14f14
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 135650f
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java 13cbde9
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java d746733
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 0485c4a
> ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java ea97524
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java 615db27
> ambari-server/src/main/java/org/apache/ambari/server/state/HostComponentAdminState.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java a982ef1
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java b940503
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHostFactory.java d535fd9
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 5deb0a7
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java b922293
> ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 1c0a66c
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql aea886a
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 9246c4a
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql fdb6eb5
> ambari-server/src/main/resources/properties.json 9c9529f
> ambari-server/src/main/resources/stacks/HDP/1.3.4/hooks/before-START/scripts/params.py 4a15586
> ambari-server/src/main/resources/stacks/HDP/1.3.4/hooks/before-START/scripts/shared_initialization.py 6243eca
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/HBASE/metainfo.xml aedb8e0
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml cd6f3a5
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/HDFS/package/scripts/hdfs_namenode.py 9830b63
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/HDFS/package/scripts/namenode.py 9b0fe43
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/HDFS/package/scripts/params.py e93c50a
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/HDFS/package/templates/exclude_hosts_list.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/metainfo.xml 1e44d2c
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/jobtracker.py a48cc23
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/params.py dd8569a
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/templates/exclude_hosts_list.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.8/hooks/before-START/scripts/params.py 0effa01
> ambari-server/src/main/resources/stacks/HDP/2.0.8/hooks/before-START/scripts/shared_initialization.py 9a1661a
> ambari-server/src/main/resources/stacks/HDP/2.0.8/services/HBASE/metainfo.xml f6db6be
> ambari-server/src/main/resources/stacks/HDP/2.0.8/services/HDFS/metainfo.xml 6cb2dfa
> ambari-server/src/main/resources/stacks/HDP/2.0.8/services/HDFS/package/scripts/hdfs_namenode.py ecda794
> ambari-server/src/main/resources/stacks/HDP/2.0.8/services/HDFS/package/scripts/namenode.py 9a1dba36
> ambari-server/src/main/resources/stacks/HDP/2.0.8/services/HDFS/package/scripts/params.py 568a8a8
> ambari-server/src/main/resources/stacks/HDP/2.0.8/services/HDFS/package/templates/exclude_hosts_list.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.8/services/YARN/metainfo.xml 127d055
> ambari-server/src/main/resources/upgrade/ddl/Ambari-DDL-MySQL-UPGRADE.sql b1ad27d
> ambari-server/src/main/resources/upgrade/ddl/Ambari-DDL-Oracle-UPGRADE.sql bcd958d
> ambari-server/src/main/resources/upgrade/ddl/Ambari-DDL-Postgres-UPGRADE-1.3.0.sql a914a3f
> ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java a31ed6e
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 552a669
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java fcaca01
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java d7e5ba7
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java 25cf6bf
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 32567f5
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 7e3a7db
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java e19250e
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestStageUtils.java 5452681
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/configuration/core-site.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/configuration/global.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/configuration/hadoop-policy.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/configuration/hdfs-site.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/metrics.json PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/files/checkForFormat.sh PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/files/checkWebUI.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/datanode.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/hdfs_client.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/hdfs_datanode.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/hdfs_namenode.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/hdfs_snamenode.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/journalnode.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/namenode.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/params.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/snamenode.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/utils.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HDFS/package/scripts/zkfc_slave.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/configuration/hive-site.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/metainfo.xml PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/files/addMysqlUser.sh PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/files/hcatSmoke.sh PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/files/hiveSmoke.sh PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/files/hiveserver2.sql PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/files/hiveserver2Smoke.sh PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/files/pigSmoke.sh PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/files/startHiveserver2.sh PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/files/startMetastore.sh PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/__init__.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/hcat.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/hcat_client.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/hcat_service_check.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/hive.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/hive_client.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/hive_metastore.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/hive_server.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/hive_service.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/mysql_server.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/mysql_service.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/params.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/templates/hcat-env.sh.j2 PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/templates/hive-env.sh.j2 PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/YARN/metainfo.xml 6f02f79
>
> Diff: https://reviews.apache.org/r/16825/diff/
>
>
> Testing
> -------
>
> AILED (failures=2)
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [0.605s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.278s]
> [INFO] Ambari Web ........................................ SUCCESS [6.671s]
> [INFO] Ambari Server ..................................... SUCCESS [12:21.392s]
> [INFO] Ambari Agent ...................................... FAILURE [4.183s]
> [INFO] Ambari Client ..................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
>
> 2 ambari-agent tests failed - known issue.
>
>
> Thanks,
>
> Sumit Mohanty
>
>