You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/02 08:30:29 UTC

[GitHub] [calcite] DonnyZone commented on a change in pull request #1776: [CALCITE-3724] Presto dialect implementation

DonnyZone commented on a change in pull request #1776:
URL: https://github.com/apache/calcite/pull/1776#discussion_r433708370



##########
File path: core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
##########
@@ -4651,7 +4707,7 @@ private void checkLiteral2(String expression, String expected) {
     sql(query).ok(expected);
   }
 
-  @Test void testCubeInSpark() {
+  @Test public void testCubeWithGroupBy() {

Review comment:
       I remember that there was a PR that removed `public`. We'd better follow this style.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org