You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Sbaia (via GitHub)" <gi...@apache.org> on 2025/11/24 11:45:07 UTC
[PR] Change volumeMounts and volumes types to array [spark-kubernetes-operator]
Sbaia opened a new pull request, #420:
URL: https://github.com/apache/spark-kubernetes-operator/pull/420
### What changes were proposed in this pull request?
This pull request updates the schema definitions in `build-tools/helm/spark-kubernetes-operator/values.schema.json` to improve compatibility with Kubernetes conventions. The main change is updating the types for `volumeMounts` and `volumes` from `object` to `array`, which better reflects how these fields are typically structured in Kubernetes manifests.
* Changed the `type` of `volumeMounts` from `object` to `array` to match standard Kubernetes configuration for container volume mounts.
* Changed the `type` of `volumes` from `object` to `array` to align with Kubernetes pod volume definitions.
### Why are the changes needed?
bug, cannot use volumes fields, the helm chart fall in error or for values.json validation, or in yaml rendering
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Change volumeMounts and volumes types to array [spark-kubernetes-operator]
Posted by "jiangzho (via GitHub)" <gi...@apache.org>.
jiangzho commented on PR #420:
URL: https://github.com/apache/spark-kubernetes-operator/pull/420#issuecomment-3619374605
Sorry for the delay - yes, this would act as a partial of SPARK-53640 . @Sbaia - could you please fix the PRBs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Change volumeMounts and volumes types to array [spark-kubernetes-operator]
Posted by "Sbaia (via GitHub)" <gi...@apache.org>.
Sbaia closed pull request #420: Change volumeMounts and volumes types to array
URL: https://github.com/apache/spark-kubernetes-operator/pull/420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org