You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/07/14 19:25:08 UTC
[GitHub] flink pull request #4345: [FLINK-7197] [gelly] Missing call to GraphAlgorith...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4345
[FLINK-7197] [gelly] Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()
Fix for methods calling the incorrect super function.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 7197_missing_call_to_can_merge_configuration_with
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4345.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4345
----
commit 31ecb4ffb74689a7a0b377a31b54ab2b205cb08a
Author: Greg Hogan <co...@greghogan.com>
Date: 2017-07-14T19:23:29Z
[FLINK-7197] [gelly] Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()
Fix for methods calling the incorrect super function.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4345: [FLINK-7197] [gelly] Missing call to GraphAlgorithmWrappi...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4345
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4345: [FLINK-7197] [gelly] Missing call to GraphAlgorithmWrappi...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4345
@tedyu does this look right to you now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4345: [FLINK-7197] [gelly] Missing call to GraphAlgorith...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4345
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4345: [FLINK-7197] [gelly] Missing call to GraphAlgorithmWrappi...
Posted by tedyu <gi...@git.apache.org>.
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4345
Fine by me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4345: [FLINK-7197] [gelly] Missing call to GraphAlgorith...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4345#discussion_r127532604
--- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/TranslateGraphIds.java ---
@@ -56,7 +56,9 @@ public TranslateGraphIds(TranslateFunction<OLD, NEW> translator) {
@Override
protected boolean canMergeConfigurationWith(GraphAlgorithmWrappingBase other) {
- super.mergeConfiguration(other);
+ if (!super.canMergeConfigurationWith(other)) {
--- End diff --
It can use the default implementation from `GraphAlgorithmWrappingBase`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4345: [FLINK-7197] [gelly] Missing call to GraphAlgorith...
Posted by tedyu <gi...@git.apache.org>.
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4345#discussion_r127532176
--- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/TranslateGraphIds.java ---
@@ -56,7 +56,9 @@ public TranslateGraphIds(TranslateFunction<OLD, NEW> translator) {
@Override
protected boolean canMergeConfigurationWith(GraphAlgorithmWrappingBase other) {
- super.mergeConfiguration(other);
+ if (!super.canMergeConfigurationWith(other)) {
--- End diff --
mergeConfiguration() wouldn't be called this way.
Is that intended ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---