[GitHub] [phoenix] virajjasani commented on a change in pull request #1035: PHOENIX-6282 : Generate PB files inline with build and remove checked in files

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #1035:
URL: https://github.com/apache/phoenix/pull/1035#discussion_r548979002



##########
File path: phoenix-core/pom.xml
##########
@@ -194,6 +194,24 @@
           </excludes>
         </configuration>
       </plugin>
+      <plugin>
+        <groupId>org.xolstice.maven.plugins</groupId>
+        <artifactId>protobuf-maven-plugin</artifactId>
+        <executions>
+          <execution>
+            <id>compile-protoc</id>
+            <phase>generate-sources</phase>
+            <goals>
+              <goal>compile</goal>
+            </goals>
+            <configuration>
+              <protoSourceRoot>${basedir}/src/main/protobuf/</protoSourceRoot>

Review comment:
       Kept version declaration property in parent pom and defined entire plugin in phoenix-core, but if declaring plugin with version on parent pom is good practice, let me change it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org