You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/07/07 01:31:20 UTC

[GitHub] [servicecomb-java-chassis] jungan21 opened a new pull request #1869: [SCB-2035]Use vertx Json and Pojo to replace own serizalization mechanism

jungan21 opened a new pull request #1869:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1869


   
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] coveralls edited a comment on pull request #1869: [SCB-2035]Use vertx Json and Pojo to replace own serizalization mechanism

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1869:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1869#issuecomment-654557252


   
   [![Coverage Status](https://coveralls.io/builds/31981517/badge)](https://coveralls.io/builds/31981517)
   
   Coverage increased (+0.05%) to 86.37% when pulling **a65b6ebe9186e64876fc603e4c0fc6438a3fa712 on jungan21:master** into **d139ada8823216a5e42b457fda36a3bee30c8abe on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] coveralls edited a comment on pull request #1869: [SCB-2035]Use vertx Json and Pojo to replace own serizalization mechanism

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1869:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1869#issuecomment-654557252


   
   [![Coverage Status](https://coveralls.io/builds/31981151/badge)](https://coveralls.io/builds/31981151)
   
   Coverage increased (+0.05%) to 86.367% when pulling **a65b6ebe9186e64876fc603e4c0fc6438a3fa712 on jungan21:master** into **d139ada8823216a5e42b457fda36a3bee30c8abe on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1869: [SCB-2035]Use vertx Json and Pojo to replace own serizalization mechanism

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1869:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1869#discussion_r452577399



##########
File path: service-registry/registry-zero-config/src/main/java/org/apache/servicecomb/zeroconfig/client/ClientUtil.java
##########
@@ -41,86 +39,68 @@
 
   private static final Logger LOGGER = LoggerFactory.getLogger(ClientUtil.class);
 
-  private static ScheduledExecutorService executor = Executors.newSingleThreadScheduledExecutor();
+  public static ClientUtil INSTANCE = new ClientUtil();
 
-  private static Microservice microserviceSelf = new Microservice();
+  private static ServerMicroserviceInstance serviceInstanceForHeartbeat = null;

Review comment:
       This is a sgingletan class, a static member seems a little bit hard to figure out if it is correct. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] coveralls edited a comment on pull request #1869: [SCB-2035]Use vertx Json and Pojo to replace own serizalization mechanism

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1869:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1869#issuecomment-654557252


   
   [![Coverage Status](https://coveralls.io/builds/31901049/badge)](https://coveralls.io/builds/31901049)
   
   Coverage increased (+0.04%) to 86.354% when pulling **5d356a7b77ec01e9463c078507e8ce4a052d8fe9 on jungan21:master** into **0d1af3fce70a442119fe65766f498428132a9d1e on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1869: [SCB-2035]Use vertx Json and Pojo to replace own serizalization mechanism

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1869:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1869#discussion_r452576656



##########
File path: service-registry/registry-zero-config/src/main/java/org/apache/servicecomb/zeroconfig/client/ClientUtil.java
##########
@@ -41,86 +39,68 @@
 
   private static final Logger LOGGER = LoggerFactory.getLogger(ClientUtil.class);
 
-  private static ScheduledExecutorService executor = Executors.newSingleThreadScheduledExecutor();
+  public static ClientUtil INSTANCE = new ClientUtil();

Review comment:
       public static field should be final. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] coveralls edited a comment on pull request #1869: [SCB-2035]Use vertx Json and Pojo to replace own serizalization mechanism

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1869:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1869#issuecomment-654557252


   
   [![Coverage Status](https://coveralls.io/builds/31922278/badge)](https://coveralls.io/builds/31922278)
   
   Coverage increased (+0.07%) to 86.379% when pulling **941b62d14f124bf5d9f2cf0cda7b107f67838593 on jungan21:master** into **0d1af3fce70a442119fe65766f498428132a9d1e on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] jungan21 commented on a change in pull request #1869: [SCB-2035]Use vertx Json and Pojo to replace own serizalization mechanism

Posted by GitBox <gi...@apache.org>.
jungan21 commented on a change in pull request #1869:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1869#discussion_r452595818



##########
File path: service-registry/registry-zero-config/src/main/java/org/apache/servicecomb/zeroconfig/client/ClientUtil.java
##########
@@ -41,86 +39,68 @@
 
   private static final Logger LOGGER = LoggerFactory.getLogger(ClientUtil.class);
 
-  private static ScheduledExecutorService executor = Executors.newSingleThreadScheduledExecutor();
+  public static ClientUtil INSTANCE = new ClientUtil();
 
-  private static Microservice microserviceSelf = new Microservice();
+  private static ServerMicroserviceInstance serviceInstanceForHeartbeat = null;

Review comment:
       changed to non-static ....




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] jungan21 commented on a change in pull request #1869: [SCB-2035]Use vertx Json and Pojo to replace own serizalization mechanism

Posted by GitBox <gi...@apache.org>.
jungan21 commented on a change in pull request #1869:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1869#discussion_r452594210



##########
File path: service-registry/registry-zero-config/src/main/java/org/apache/servicecomb/zeroconfig/client/ClientUtil.java
##########
@@ -41,86 +39,68 @@
 
   private static final Logger LOGGER = LoggerFactory.getLogger(ClientUtil.class);
 
-  private static ScheduledExecutorService executor = Executors.newSingleThreadScheduledExecutor();
+  public static ClientUtil INSTANCE = new ClientUtil();

Review comment:
       agreed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1869: [SCB-2035]Use vertx Json and Pojo to replace own serizalization mechanism

Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #1869:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1869


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] coveralls commented on pull request #1869: [SCB-2035]Use vertx Json and Pojo to replace own serizalization mechanism

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1869:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1869#issuecomment-654557252


   
   [![Coverage Status](https://coveralls.io/builds/31898309/badge)](https://coveralls.io/builds/31898309)
   
   Coverage increased (+0.03%) to 86.342% when pulling **d7c56b009fe5e52aa95896c901e1db590bffbb76 on jungan21:master** into **0d1af3fce70a442119fe65766f498428132a9d1e on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org