You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/01/28 17:22:01 UTC

[GitHub] [geode] DonalEvans commented on a change in pull request #7321: GEODE-9993: Make SMOVE transactional

DonalEvans commented on a change in pull request #7321:
URL: https://github.com/apache/geode/pull/7321#discussion_r794704775



##########
File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
##########
@@ -415,6 +413,14 @@ public long sadd(List<byte[]> membersToAdd, Region<RedisKey, RedisData> region,
     return membersAdded;
   }
 
+  void addForSmove(byte[] memberToAdd, Region<RedisKey, RedisData> region, RedisKey key) {

Review comment:
       Since moving the transaction check into `AbstractRedisData` would require refactoring all methods that currently call `storeChanges()` to pass in a `RegionProvider` instead of a `Region`, I've moved the check to `sadd` and `srem` for now to limit the impact of this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org