You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@metron.apache.org by anandsubbu <gi...@git.apache.org> on 2018/02/16 14:35:37 UTC

[GitHub] metron pull request #938: METRON-1457: Move ASF links to main page in the Me...

GitHub user anandsubbu opened a pull request:

    https://github.com/apache/metron/pull/938

    METRON-1457: Move ASF links to main page in the Metron website

    ## Contributor Comments
    Apache Whimsy checks for the site requisites in the main index.html and not inside sub-levels. This PR moves the content of the ASF and links to the main page.
    
    Here is a screenshot of how the new metron page will look like:
    https://imgur.com/3Y8ZLWL
    
    **Testing Steps**
    Follow the below steps to test the changes
    
    * From `metron/site` execute
    ```
    bundle install
    bundle exec jekyll serve
    ```
    * Navigate to http://localhost:4000 to review the site
    
    Note that these steps are an excerpt from https://cwiki.apache.org/confluence/display/METRON/Website+PR+Merge. Please follow this page to have the pre-requisites set up.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anandsubbu/incubator-metron METRON-1457

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/938.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #938
    
----
commit dda05791a3667859be6159abc814a59af506ed09
Author: Anand Subramanian <as...@...>
Date:   2018-02-16T14:27:55Z

    Move ASF links to the main page

----


---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

Posted by anandsubbu <gi...@git.apache.org>.

Github user anandsubbu commented on the issue:

    https://github.com/apache/metron/pull/938
  
    Thank you @mmiklavc and @nickwallen for your reply on the dev list. 
    
    Any feedback on this PR? 


---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

Posted by cestella <gi...@git.apache.org>.

Github user cestella commented on the issue:

    https://github.com/apache/metron/pull/938
  
    +1 as well, looks great



---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

Posted by anandsubbu <gi...@git.apache.org>.

Github user anandsubbu commented on the issue:

    https://github.com/apache/metron/pull/938
  
    Roger that. Here's the new look. Let me know if this looks ok @justinleet and @cestella .
    
    ![image](https://user-images.githubusercontent.com/20395490/36736657-323cff0a-1bff-11e8-8d13-b47a47193fa4.png)



---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

Posted by anandsubbu <gi...@git.apache.org>.

Github user anandsubbu commented on the issue:

    https://github.com/apache/metron/pull/938
  
    Thanks all.


---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

Posted by mmiklavc <gi...@git.apache.org>.

Github user mmiklavc commented on the issue:

    https://github.com/apache/metron/pull/938
  
    +1 from me as well, thanks @anandsubbu!


---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

Posted by cestella <gi...@git.apache.org>.

Github user cestella commented on the issue:

    https://github.com/apache/metron/pull/938
  
    Where is that powered by apache logo from?  Are we sure it doesn't mean that the apache web server serves it up?


---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

Posted by anandsubbu <gi...@git.apache.org>.

Github user anandsubbu commented on the issue:

    https://github.com/apache/metron/pull/938
  
    Thanks @justinleet for the pointer. I have made a change to use the Powered By logo instead of the foundation logo with feather, since I thought this looked better. I also added a direct link to the ASF press kit page, instead of storing the image on our local site. 
    
    Let me know your thoughts. 
    
    <img width="1402" alt="with-poweredby-logo" src="https://user-images.githubusercontent.com/20395490/36713710-ee7afc76-1bb4-11e8-9c06-a19bd20c17fd.png">



---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

Posted by justinleet <gi...@git.apache.org>.

Github user justinleet commented on the issue:

    https://github.com/apache/metron/pull/938
  
    +1, pending Travis. I think any look complaints after this are follow-on, given that this addresses the main issues we wanted and has the updated mark.


---

[GitHub] metron issue #938: METRON-1457: Move ASF links to main page in the Metron we...

Posted by justinleet <gi...@git.apache.org>.

Github user justinleet commented on the issue:

    https://github.com/apache/metron/pull/938
  
    The Apache logo image used is a bit outdated.  Could you swap it with the latest?
    
    Looks like it's at https://www.apache.org/foundation/press/kit/#links.  I can only find it from the press links, but if anyone knows a better place to grab it from, we can pull from there.


---