You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/03 06:29:04 UTC

[jira] [Commented] (BEAM-1415) PubsubIO should comply with PTransform style guide

    [ https://issues.apache.org/jira/browse/BEAM-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994339#comment-15994339 ] 

ASF GitHub Bot commented on BEAM-1415:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2634


> PubsubIO should comply with PTransform style guide
> --------------------------------------------------
>
>                 Key: BEAM-1415
>                 URL: https://issues.apache.org/jira/browse/BEAM-1415
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-gcp
>            Reporter: Eugene Kirpichov
>            Assignee: Eugene Kirpichov
>              Labels: backward-incompatible, easy, starter
>             Fix For: First stable release
>
>
> Suggested changes:
> - Rename builder methods such as .subscription(), .topic() etc. to .withSubscription, .withTopic()
> - Replace use of Coder from the API (.withCoder()) with a SerializableFunction
> - Rename .withAttributes() to something else, because it sounds like this is a function that sets attributes.
> - (optional) use AutoValue



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)