You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by yu...@apache.org on 2023/03/12 14:08:32 UTC
[spark] branch master updated: [MINOR][SQL] Fix incorrect comment in LimitPushDownThroughWindow
This is an automated email from the ASF dual-hosted git repository.
yumwang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new c75b3ab6f60 [MINOR][SQL] Fix incorrect comment in LimitPushDownThroughWindow
c75b3ab6f60 is described below
commit c75b3ab6f608037b6e210d60e29392f59d113a8a
Author: kangzhipeng-xs <19...@qq.com>
AuthorDate: Sun Mar 12 22:08:13 2023 +0800
[MINOR][SQL] Fix incorrect comment in LimitPushDownThroughWindow
### What changes were proposed in this pull request?
Fix incorrect comment in `LimitPushDownThroughWindow`.
### Why are the changes needed?
Fix incorrect comment.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No need.
Closes #40365 from kenny-ddd/test-1.
Authored-by: kangzhipeng-xs <19...@qq.com>
Signed-off-by: Yuming Wang <yu...@ebay.com>
---
.../spark/sql/catalyst/optimizer/LimitPushDownThroughWindow.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/LimitPushDownThroughWindow.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/LimitPushDownThroughWindow.scala
index 88f92262dcc..b4174ab18a4 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/LimitPushDownThroughWindow.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/LimitPushDownThroughWindow.scala
@@ -30,7 +30,7 @@ import org.apache.spark.sql.catalyst.trees.TreePattern.{LIMIT, WINDOW}
* }}}
*/
object LimitPushDownThroughWindow extends Rule[LogicalPlan] {
- // The window frame of RankLike and RowNumberLike can only be UNBOUNDED PRECEDING to CURRENT ROW.
+ // The window frame of Rank, DenseRank and RowNumber can only be UNBOUNDED PRECEDING to CURRENT ROW.
private def supportsPushdownThroughWindow(
windowExpressions: Seq[NamedExpression]): Boolean = windowExpressions.forall {
case Alias(WindowExpression(_: Rank | _: DenseRank | _: RowNumber, WindowSpecDefinition(Nil, _,
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org