[jira] [Commented] (KNOX-1874) Ignore irrelevant files in service definition directories

["Todd Lipcon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KNOX-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858122#comment-16858122 ] 

Todd Lipcon commented on KNOX-1874:
-----------------------------------

It seems like the current code tries to load an file with the name 'service' in it. I think we could restrict this to:
- skip any hidden files (leading '.')
- skip any files without '.xml' extension

What I'm not sure is why we actually have a loop here at all instead of just looking for 'service.xml' directly -- it seems all definitions use exactly that naming convention. [~lmccay] any idea?

> Ignore irrelevant files in service definition directories
> ---------------------------------------------------------
>
>                 Key: KNOX-1874
>                 URL: https://issues.apache.org/jira/browse/KNOX-1874
>             Project: Apache Knox
>          Issue Type: Bug
>            Reporter: Todd Lipcon
>            Priority: Major
>
> I was working on editing a service definition file, which resulted in creating an emacs lock file '#service.xml#' in the service directory. Knox was attempting to load this file, failing to parse it, and ignoring my service.
> ServiceDefinitionLoader should only load properly named service definition XML files and skip irrelevant items.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)