You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/09/10 22:08:38 UTC
[GitHub] [nifi] naddym opened a new pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
naddym opened a new pull request #4520:
URL: https://github.com/apache/nifi/pull/4520
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a change in pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487172087
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
The standard convention for properties with a set of allowable values is to make the property required. Functionally it doesn't matter but I will set it to true for consistency when I merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #4520:
URL: https://github.com/apache/nifi/pull/4520
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] naddym commented on a change in pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
naddym commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487199329
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
Sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] naddym commented on pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
naddym commented on pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#issuecomment-691219583
Thanks @mattyb149 for the review and the merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] naddym commented on a change in pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
naddym commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487080018
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
Sure @mattyb149 I will add it. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] naddym commented on a change in pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
naddym commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487080018
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
Sure @mattyb149 I will add it. Thanks
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
Sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] naddym commented on pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
naddym commented on pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#issuecomment-691219583
Thanks @mattyb149 for the review and the merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a change in pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487072327
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
I didn't see a unit test where omitDeclaration is set to true, let's make sure there is one and we verify that the header is not written out when true.
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
The standard convention for properties with a set of allowable values is to make the property required. Functionally it doesn't matter but I will set it to true for consistency when I merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] naddym commented on pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
naddym commented on pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#issuecomment-691219583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #4520:
URL: https://github.com/apache/nifi/pull/4520
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] naddym commented on a change in pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
naddym commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487080018
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
Sure @mattyb149 I will add it. Thanks
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
Sure
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
Sure @mattyb149 I will add it. Thanks
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
Sure
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
Sure @mattyb149 I will add it. Thanks
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
Sure
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
Sure @mattyb149 I will add it. Thanks
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
Sure
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
Sure @mattyb149 I will add it. Thanks
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
Sure
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
Sure @mattyb149 I will add it. Thanks
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
Sure
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
Sure @mattyb149 I will add it. Thanks
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
Sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] naddym commented on pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
naddym commented on pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#issuecomment-691219583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a change in pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487072327
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
I didn't see a unit test where omitDeclaration is set to true, let's make sure there is one and we verify that the header is not written out when true.
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
The standard convention for properties with a set of allowable values is to make the property required. Functionally it doesn't matter but I will set it to true for consistency when I merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a change in pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487072327
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
I didn't see a unit test where omitDeclaration is set to true, let's make sure there is one and we verify that the header is not written out when true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#issuecomment-691211449
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a change in pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487072327
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
I didn't see a unit test where omitDeclaration is set to true, let's make sure there is one and we verify that the header is not written out when true.
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
The standard convention for properties with a set of allowable values is to make the property required. Functionally it doesn't matter but I will set it to true for consistency when I merge.
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
I didn't see a unit test where omitDeclaration is set to true, let's make sure there is one and we verify that the header is not written out when true.
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
The standard convention for properties with a set of allowable values is to make the property required. Functionally it doesn't matter but I will set it to true for consistency when I merge.
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
I didn't see a unit test where omitDeclaration is set to true, let's make sure there is one and we verify that the header is not written out when true.
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
The standard convention for properties with a set of allowable values is to make the property required. Functionally it doesn't matter but I will set it to true for consistency when I merge.
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
I didn't see a unit test where omitDeclaration is set to true, let's make sure there is one and we verify that the header is not written out when true.
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
The standard convention for properties with a set of allowable values is to make the property required. Functionally it doesn't matter but I will set it to true for consistency when I merge.
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
I didn't see a unit test where omitDeclaration is set to true, let's make sure there is one and we verify that the header is not written out when true.
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
The standard convention for properties with a set of allowable values is to make the property required. Functionally it doesn't matter but I will set it to true for consistency when I merge.
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
I didn't see a unit test where omitDeclaration is set to true, let's make sure there is one and we verify that the header is not written out when true.
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
The standard convention for properties with a set of allowable values is to make the property required. Functionally it doesn't matter but I will set it to true for consistency when I merge.
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
I didn't see a unit test where omitDeclaration is set to true, let's make sure there is one and we verify that the header is not written out when true.
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
The standard convention for properties with a set of allowable values is to make the property required. Functionally it doesn't matter but I will set it to true for consistency when I merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #4520:
URL: https://github.com/apache/nifi/pull/4520
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #4520:
URL: https://github.com/apache/nifi/pull/4520
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] naddym commented on a change in pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
naddym commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487080018
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestWriteXMLResult.java
##########
@@ -85,7 +85,7 @@ public void testRecordNameIsNullSchemaIdentifierMissing() {
try {
new WriteXMLResult(recordSet.getSchema(), new SchemaNameAsAttribute(),
- out, true, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
+ out, true, false, ALWAYS_SUPPRESS, NO_WRAPPING, null, "root", null, "UTF-8", DATE_FORMAT, TIME_FORMAT, TIMESTAMP_FORMAT);
Review comment:
Sure @mattyb149 I will add it. Thanks
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml/XMLRecordSetWriter.java
##########
@@ -80,6 +80,16 @@
.required(true)
.build();
+ public static final PropertyDescriptor OMIT_XML_DECLARATION = new PropertyDescriptor.Builder()
+ .name("omit_xml_declaration")
+ .displayName("Omit XML Declaration")
+ .description("Specifies whether or not to include XML declaration")
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(false)
Review comment:
Sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#issuecomment-691211449
+1 LGTM, ran contrib-check and tried on a live instance with both settings (true and false), verified the behavior is as described. Thanks for the improvement! Merging to main
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #4520: NIFI-7800: Provide an option to omit XML declaration for XMLRecordSetWriter
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#issuecomment-691211449
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org