You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2021/09/18 13:47:55 UTC
[isis] branch master updated: ISIS-2871: fix input max/typical
lengths for byte/short/int/long
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/master by this push:
new dbaa9a7 ISIS-2871: fix input max/typical lengths for byte/short/int/long
dbaa9a7 is described below
commit dbaa9a751c4ab0050d76c413068435e22b9d7c71
Author: andi-huber <ah...@apache.org>
AuthorDate: Sat Sep 18 15:47:06 2021 +0200
ISIS-2871: fix input max/typical lengths for byte/short/int/long
---
.../isis/core/metamodel/valuesemantics/ByteValueSemantics.java | 6 ++++--
.../isis/core/metamodel/valuesemantics/IntValueSemantics.java | 8 +++++---
.../isis/core/metamodel/valuesemantics/LongValueSemantics.java | 8 +++++---
.../isis/core/metamodel/valuesemantics/ShortValueSemantics.java | 6 ++++--
4 files changed, 18 insertions(+), 10 deletions(-)
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/ByteValueSemantics.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/ByteValueSemantics.java
index 4fe9b12..fd6ef7c 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/ByteValueSemantics.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/ByteValueSemantics.java
@@ -92,12 +92,14 @@ implements
@Override
public int typicalLength() {
- return maxLength();
+ //-128
+ return 4;
}
@Override
public int maxLength() {
- return 4;
+ //-128.0
+ return 6;
}
}
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/IntValueSemantics.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/IntValueSemantics.java
index 22d7075..c440a31 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/IntValueSemantics.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/IntValueSemantics.java
@@ -34,7 +34,7 @@ import org.apache.isis.commons.internal.base._Strings;
* due to auto-boxing also handles the primitive variant
*/
@Component
-@Named("isis.val.ByteValueSemantics")
+@Named("isis.val.IntValueSemantics")
public class IntValueSemantics
extends AbstractValueSemanticsProvider<Integer>
implements
@@ -92,12 +92,14 @@ implements
@Override
public int typicalLength() {
- return maxLength();
+ //-2147483648
+ return 11;
}
@Override
public int maxLength() {
- return 9;
+ //-2,147,483,648.0
+ return 16;
}
}
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/LongValueSemantics.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/LongValueSemantics.java
index 79775db..2f1eb10 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/LongValueSemantics.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/LongValueSemantics.java
@@ -34,7 +34,7 @@ import org.apache.isis.commons.internal.base._Strings;
* due to auto-boxing also handles the primitive variant
*/
@Component
-@Named("isis.val.ByteValueSemantics")
+@Named("isis.val.LongValueSemantics")
public class LongValueSemantics
extends AbstractValueSemanticsProvider<Long>
implements
@@ -92,12 +92,14 @@ implements
@Override
public int typicalLength() {
- return maxLength();
+ // -9223372036854775808
+ return 20;
}
@Override
public int maxLength() {
- return 18;
+ // -9,223,372,036,854,775,808.0
+ return 28;
}
}
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/ShortValueSemantics.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/ShortValueSemantics.java
index 1cd6311..542daf4 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/ShortValueSemantics.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/valuesemantics/ShortValueSemantics.java
@@ -92,12 +92,14 @@ implements
@Override
public int typicalLength() {
- return maxLength();
+ //-32768
+ return 6;
}
@Override
public int maxLength() {
- return 6;
+ //-32,768.0
+ return 9;
}
}