You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/09/03 20:44:56 UTC
[GitHub] [fineract] hmg65 opened a new pull request, #2565: FINERACT-1715: Introduce Lombok to cob module
hmg65 opened a new pull request, #2565:
URL: https://github.com/apache/fineract/pull/2565
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #2565: FINERACT-1715: Introduce Lombok to cob module
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #2565: FINERACT-1715: Introduce Lombok to cob module
URL: https://github.com/apache/fineract/pull/2565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2565: FINERACT-1715: Introduce Lombok to cob module
Posted by GitBox <gi...@apache.org>.
galovics commented on PR #2565:
URL: https://github.com/apache/fineract/pull/2565#issuecomment-1274484683
PR conflicting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2565: FINERACT-1715: Introduce Lombok to cob module
Posted by GitBox <gi...@apache.org>.
galovics commented on PR #2565:
URL: https://github.com/apache/fineract/pull/2565#issuecomment-1279679813
PR conflicting still.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] luckyman20 commented on pull request #2565: FINERACT-1715: Introduce Lombok to cob module
Posted by GitBox <gi...@apache.org>.
luckyman20 commented on PR #2565:
URL: https://github.com/apache/fineract/pull/2565#issuecomment-1293775484
@galovics I do not see any conflicts while merging with the base branch.
@hmg65 Please squash the commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #2565: FINERACT-1715: Introduce Lombok to cob module
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #2565:
URL: https://github.com/apache/fineract/pull/2565#issuecomment-1352391048
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2565: FINERACT-1715: Introduce Lombok to cob module
Posted by GitBox <gi...@apache.org>.
galovics commented on PR #2565:
URL: https://github.com/apache/fineract/pull/2565#issuecomment-1293244519
@hmg65 PR is still conflicting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2565: FINERACT-1715: Introduce Lombok to cob module
Posted by GitBox <gi...@apache.org>.
galovics commented on PR #2565:
URL: https://github.com/apache/fineract/pull/2565#issuecomment-1245346521
PR conflicting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org