You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/07 15:07:46 UTC
[GitHub] [arrow] anthonylouisbsb opened a new pull request #10468: ARROW-12987: [CI] test-ubuntu-18.04 nightly builds are failing due to Gandiva "TestUpper" test failure
anthonylouisbsb opened a new pull request #10468:
URL: https://github.com/apache/arrow/pull/10468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb removed a comment on pull request #10468: ARROW-12987: [CI] test-ubuntu-18.04 nightly builds are failing due to Gandiva "TestUpper" test failure
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb removed a comment on pull request #10468:
URL: https://github.com/apache/arrow/pull/10468#issuecomment-856097519
@github-actions crossbow submit test-ubuntu-18.04-cpp-static test-ubuntu-18.04-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on pull request #10468: ARROW-12987: [CI] test-ubuntu-18.04 nightly builds are failing due to Gandiva "TestUpper" test failure
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on pull request #10468:
URL: https://github.com/apache/arrow/pull/10468#issuecomment-856165761
@kszucs Thanks for running the builds, I did not know that I can run the comment bot.
BTW, the builds are passing, so I think the changes are working fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10468: ARROW-12987: [C++][CI] Switch to bundled utf8proc with version 2.2 in Ubuntu 18.04 images
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10468:
URL: https://github.com/apache/arrow/pull/10468#issuecomment-856188250
https://issues.apache.org/jira/browse/ARROW-12987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on pull request #10468: ARROW-12987: [C++][CI] Switch to bundled utf8proc with version 2.2 in Ubuntu 18.04 images
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on pull request #10468:
URL: https://github.com/apache/arrow/pull/10468#issuecomment-856364583
@kou You are correct, I forgot to add it in this PR, I will open a new one adding that check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10468: ARROW-12987: [C++][CI] Switch to bundled utf8proc with version 2.2 in Ubuntu 18.04 images
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10468:
URL: https://github.com/apache/arrow/pull/10468#issuecomment-856347802
If we require utf8proc 2.2.0 or later, how about adding version check in CMake?
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index ff55936c2..1350f2745 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -2275,7 +2275,7 @@ macro(build_utf8proc)
endmacro()
if(ARROW_WITH_UTF8PROC)
- resolve_dependency(utf8proc)
+ resolve_dependency(utf8proc REQUIRED_VERSION "2.2.0")
add_definitions(-DARROW_WITH_UTF8PROC)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #10468: ARROW-12987: [C++][CI] Switch to bundled utf8proc with version 2.2 in Ubuntu 18.04 images
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #10468:
URL: https://github.com/apache/arrow/pull/10468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on pull request #10468: ARROW-12987: [C++][CI] Switch to bundled utf8proc with version 2.2 in Ubuntu 18.04 images
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on pull request #10468:
URL: https://github.com/apache/arrow/pull/10468#issuecomment-856424568
@kou I created a PR adding the check about the UTF8PROC version:
https://github.com/apache/arrow/pull/10477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on pull request #10468: ARROW-12987: [CI] test-ubuntu-18.04 nightly builds are failing due to Gandiva "TestUpper" test failure
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on pull request #10468:
URL: https://github.com/apache/arrow/pull/10468#issuecomment-856069742
@kszucs I think I do not have permission to manually start the crossbow builds using the bot.
So could you submit the `test-ubuntu-18.04-cpp-static` and the `test-ubuntu-18.04-cpp` nightly builds from this branch? Then we can check if the changes are fine and correct the problem. I already made some tests locally and are fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylgf commented on pull request #10468: ARROW-12987: [C++][CI] Switch to bundled utf8proc with version 2.2 in Ubuntu 18.04 images
Posted by GitBox <gi...@apache.org>.
anthonylgf commented on pull request #10468:
URL: https://github.com/apache/arrow/pull/10468#issuecomment-856364217
@kou You are correct, I forgot to add it in this Pull Request. I will open a new one adding that check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10468: ARROW-12987: [CI] test-ubuntu-18.04 nightly builds are failing due to Gandiva "TestUpper" test failure
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10468:
URL: https://github.com/apache/arrow/pull/10468#issuecomment-856107647
Revision: ec1b092e7ca93b0ab8925d2bc95f1a65c27035c8
Submitted crossbow builds: [ursacomputing/crossbow @ actions-480](https://github.com/ursacomputing/crossbow/branches/all?query=actions-480)
|Task|Status|
|----|------|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-480-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-480-github-test-ubuntu-18.04-cpp-static)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylgf removed a comment on pull request #10468: ARROW-12987: [C++][CI] Switch to bundled utf8proc with version 2.2 in Ubuntu 18.04 images
Posted by GitBox <gi...@apache.org>.
anthonylgf removed a comment on pull request #10468:
URL: https://github.com/apache/arrow/pull/10468#issuecomment-856364217
@kou You are correct, I forgot to add it in this Pull Request. I will open a new one adding that check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10468: ARROW-12987: [CI] test-ubuntu-18.04 nightly builds are failing due to Gandiva "TestUpper" test failure
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10468:
URL: https://github.com/apache/arrow/pull/10468#issuecomment-856086724
@github-actions crossbow submit test-ubuntu-18.04-cpp-static test-ubuntu-18.04-cpp
Thanks @anthonylouisbsb for the fix! BTW The comment bot should allow you to submit crossbow tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] anthonylouisbsb commented on pull request #10468: ARROW-12987: [CI] test-ubuntu-18.04 nightly builds are failing due to Gandiva "TestUpper" test failure
Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on pull request #10468:
URL: https://github.com/apache/arrow/pull/10468#issuecomment-856097519
@github-actions crossbow submit test-ubuntu-18.04-cpp-static test-ubuntu-18.04-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org