You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/07/13 00:00:46 UTC
[GitHub] [commons-csv] belugabehr opened a new pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
belugabehr opened a new pull request #162:
URL: https://github.com/apache/commons-csv/pull/162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#issuecomment-879161167
This PR has no description or URL to the Jira ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory edited a comment on pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#issuecomment-879161167
This PR has no description or URL to the Jira ticket.
Is this supposed to improve performance? If so please show your JMH results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #162:
URL: https://github.com/apache/commons-csv/pull/162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] coveralls edited a comment on pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#issuecomment-878688255
[](https://coveralls.io/builds/41315706)
Coverage increased (+0.003%) to 98.313% when pulling **c7dec1c0be50f48e3d7f8df156f4a114905ae46b on belugabehr:CSV-278** into **3b959626f4c1ad31a4f8fbdcba513e12fc6f7f3d on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] belugabehr commented on pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#issuecomment-880010202
@garydgregory Have you had a chance to check out the JMH stuff? Thanks!
https://issues.apache.org/jira/browse/CSV-278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] belugabehr commented on pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#issuecomment-879533005
@garydgregory I posted some local results to the comment section of the JIRA. Thanks!
https://issues.apache.org/jira/browse/CSV-278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on a change in pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#discussion_r668343890
##########
File path: src/main/java/org/apache/commons/csv/ExtendedBufferedReader.java
##########
@@ -132,10 +132,24 @@ int lookAhead() throws IOException {
*/
char[] lookAhead(final int n) throws IOException {
final char[] buf = new char[n];
Review comment:
The local var is not needed anymore right?
##########
File path: src/main/java/org/apache/commons/csv/Lexer.java
##########
@@ -153,25 +156,26 @@ boolean isEscape(final int ch) {
}
/**
- * Tests if the next characters constitute a escape delimiter through {@link ExtendedBufferedReader#lookAhead(int)}.
+ * Tests if the next characters constitute a escape delimiter through
+ * {@link ExtendedBufferedReader#lookAhead(char[])}.
*
Review comment:
Same comment.
##########
File path: src/main/java/org/apache/commons/csv/Lexer.java
##########
@@ -112,25 +116,24 @@ boolean isCommentStart(final int ch) {
}
/**
- * Determine whether the next characters constitute a delimiter through {@link ExtendedBufferedReader#lookAhead(int)}
+ * Determine whether the next characters constitute a delimiter through
Review comment:
No need to change for formatted, it makes more noise to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#issuecomment-880044633
Maybe tonight or this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] belugabehr commented on a change in pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#discussion_r668380832
##########
File path: src/main/java/org/apache/commons/csv/ExtendedBufferedReader.java
##########
@@ -132,10 +132,24 @@ int lookAhead() throws IOException {
*/
char[] lookAhead(final int n) throws IOException {
final char[] buf = new char[n];
Review comment:
Actually, it's still used in `CSVFormat#printWithEscapes`. I am happy to remove fully in another PR, but wanted to keep change as small as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] belugabehr commented on pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#issuecomment-879496982
@garydgregory Thanks so much. I've got one more change to propose after this then I'll share with you perf numbers between master and previous release. Thanks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#issuecomment-879161545
This PR has no description or URL to the Jira ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#issuecomment-879529981
@belugabehr
Please provide JMH numbers for this PR if you are providing this for performance reasons. Otherwise, it's just a change to complex code not backed up by anything.
If you want to put more in this PR that is fine as well.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] coveralls commented on pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#issuecomment-878688255
[](https://coveralls.io/builds/41311495)
Coverage increased (+0.003%) to 98.313% when pulling **7c2427be579ea39d3a815421200495a0a23df578 on belugabehr:CSV-278** into **3b959626f4c1ad31a4f8fbdcba513e12fc6f7f3d on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] coveralls edited a comment on pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#issuecomment-878688255
[](https://coveralls.io/builds/41347414)
Coverage increased (+0.003%) to 98.314% when pulling **feb90c1538174c66019e3019601d31400f26419d on belugabehr:CSV-278** into **bda783580a223a8505214b386c3fa94e5a8ac6f3 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #162: CSV-278: Reuse Buffers in Lexer for Delimiter Detection
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #162:
URL: https://github.com/apache/commons-csv/pull/162#issuecomment-879491310
@belugabehr
May you please resolve conflicts and post your JMH benchmark results?
TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org