You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/11 21:35:48 UTC
[GitHub] [airflow] utkarsharma2 opened a new pull request #21530: Added template_ext = ('.json') to databricks operators #18925
utkarsharma2 opened a new pull request #21530:
URL: https://github.com/apache/airflow/pull/21530
related: #18925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21530: Added template_ext = ('.json') to databricks operators #18925
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21530:
URL: https://github.com/apache/airflow/pull/21530#issuecomment-1037217272
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21530: Added template_ext = ('.json') to databricks operators #18925
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21530:
URL: https://github.com/apache/airflow/pull/21530#issuecomment-1037217272
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #21530: Added template_ext = ('.json') to databricks operators #18925
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21530:
URL: https://github.com/apache/airflow/pull/21530#discussion_r805054394
##########
File path: airflow/providers/databricks/operators/databricks.py
##########
@@ -246,6 +246,7 @@ class DatabricksSubmitRunOperator(BaseOperator):
# Used in airflow.models.BaseOperator
template_fields: Sequence[str] = ('json',)
+ template_ext: Sequence[str] = ('json',)
Review comment:
You should add it as ".json" not "json"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] utkarsharma2 commented on a change in pull request #21530: Added template_ext = ('.json') to databricks operators #18925
Posted by GitBox <gi...@apache.org>.
utkarsharma2 commented on a change in pull request #21530:
URL: https://github.com/apache/airflow/pull/21530#discussion_r805116768
##########
File path: airflow/providers/databricks/operators/databricks.py
##########
@@ -246,6 +246,7 @@ class DatabricksSubmitRunOperator(BaseOperator):
# Used in airflow.models.BaseOperator
template_fields: Sequence[str] = ('json',)
+ template_ext: Sequence[str] = ('json',)
Review comment:
@potiuk , I'll update PR with a '.json' extension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21530: Added template_ext = ('.json') to databricks operators #18925
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21530:
URL: https://github.com/apache/airflow/pull/21530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21530: Added template_ext = ('.json') to databricks operators #18925
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21530:
URL: https://github.com/apache/airflow/pull/21530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21530: Added template_ext = ('.json') to databricks operators #18925
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21530:
URL: https://github.com/apache/airflow/pull/21530#issuecomment-1036707022
I see that you closed a ".json" change? what was the reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org