[GitHub] spark issue #18111: [SPARK-20886][CORE] HadoopMapReduceCommitProtocol to han...

[HyukjinKwon <gi...@git.apache.org>]

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/18111
  
    OK. LGTM. I think this anyway should issue warnings:
    
    ```
    WARN org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter: Output Path is null in setupJob()
    WARN org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter: Output Path is null in commitJob()
    ```
    
    and I assume we prefer working permissively rather than failing fast. At least, it looks that's what `FileOutputCommitter` allows even if it skips moving the output.
    
    Please make a followup if I misunderstood and anything is wrong. Will merge this one in few days. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org