You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ne...@apache.org on 2017/05/10 04:58:31 UTC

[7/8] mesos git commit: Cleaned up comments in stout's Version.

Cleaned up comments in stout's Version.

Review: https://reviews.apache.org/r/59122


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/f63d1157
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/f63d1157
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/f63d1157

Branch: refs/heads/1.3.x
Commit: f63d1157b4f0ae786f1cd9ffab9a8a9274f3eced
Parents: d43d745
Author: Neil Conway <ne...@gmail.com>
Authored: Tue May 9 17:52:20 2017 -0700
Committer: Neil Conway <ne...@gmail.com>
Committed: Tue May 9 21:29:33 2017 -0700

----------------------------------------------------------------------
 3rdparty/stout/include/stout/version.hpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/f63d1157/3rdparty/stout/include/stout/version.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/stout/include/stout/version.hpp b/3rdparty/stout/include/stout/version.hpp
index bff6e4c..b396cad 100644
--- a/3rdparty/stout/include/stout/version.hpp
+++ b/3rdparty/stout/include/stout/version.hpp
@@ -38,11 +38,6 @@
 //
 // TODO(neilc): Consider providing a "strict" variant that does not
 // allow these extensions.
-//
-// Ideally, the version components would be called simply "major",
-// "minor", and "patch". However, GNU libstdc++ already defines these
-// as macros for compatibility reasons (man 3 makedev for more
-// information) implicitly included in every compilation.
 struct Version
 {
   // Expect the string in the following format:
@@ -55,6 +50,11 @@ struct Version
   // consist of one or more dot-separated identifiers. An identifier
   // is a non-empty string containing ASCII alphanumeric characters or
   // hyphens.
+  //
+  // Ideally, the version components would be called simply "major",
+  // "minor", and "patch". However, GNU libstdc++ already defines
+  // these as macros for compatibility reasons (man 3 makedev for more
+  // information) implicitly included in every compilation.
   static Try<Version> parse(const std::string& input)
   {
     // The input string consists of the numeric components, optionally