You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Richard Liang (JIRA)" <ji...@apache.org> on 2006/07/14 12:22:14 UTC
[jira] Created: (HARMONY-876) Refactor java.util.Formatter:
FloatUtil.transform
Refactor java.util.Formatter: FloatUtil.transform
-------------------------------------------------
Key: HARMONY-876
URL: http://issues.apache.org/jira/browse/HARMONY-876
Project: Harmony
Issue Type: Improvement
Components: Classlib
Reporter: Richard Liang
Priority: Minor
Attachments: luni.src.diff
Hello,
I try to refactor some code of java.util.Formatter which is related to FloatUtil.transform. I will attach the patch soon :-)
Best regards,
Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-876) Refactor java.util.Formatter:
FloatUtil.transform
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-876?page=all ]
George Harley resolved HARMONY-876.
-----------------------------------
Resolution: Fixed
Hi Richard,
Changes committed in revision 422660. Please could you verify that they have been applied as expected. Note that I made one minor change which was to add a default case to the switch statement in the FormatUtil.transform(FormatToken, StringBuilder) method that starts on line 1637. The case throws a UnknownFormatConversionException - is that acceptable to you ?
Best regards,
George
> Refactor java.util.Formatter: FloatUtil.transform
> -------------------------------------------------
>
> Key: HARMONY-876
> URL: http://issues.apache.org/jira/browse/HARMONY-876
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Assigned To: George Harley
> Priority: Minor
> Attachments: luni.src.diff
>
>
> Hello,
> I try to refactor some code of java.util.Formatter which is related to FloatUtil.transform. I will attach the patch soon :-)
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-876) Refactor java.util.Formatter:
FloatUtil.transform
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-876?page=comments#action_12421754 ]
Richard Liang commented on HARMONY-876:
---------------------------------------
Hello George,
The default case and the overall fix look fine. :-) Thank you.
Best regards,
Richard.
> Refactor java.util.Formatter: FloatUtil.transform
> -------------------------------------------------
>
> Key: HARMONY-876
> URL: http://issues.apache.org/jira/browse/HARMONY-876
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Assigned To: George Harley
> Priority: Minor
> Attachments: luni.src.diff
>
>
> Hello,
> I try to refactor some code of java.util.Formatter which is related to FloatUtil.transform. I will attach the patch soon :-)
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-876) Refactor java.util.Formatter:
FloatUtil.transform
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-876?page=all ]
George Harley reassigned HARMONY-876:
-------------------------------------
Assignee: George Harley
> Refactor java.util.Formatter: FloatUtil.transform
> -------------------------------------------------
>
> Key: HARMONY-876
> URL: http://issues.apache.org/jira/browse/HARMONY-876
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Assigned To: George Harley
> Priority: Minor
> Attachments: luni.src.diff
>
>
> Hello,
> I try to refactor some code of java.util.Formatter which is related to FloatUtil.transform. I will attach the patch soon :-)
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-876) Refactor java.util.Formatter:
FloatUtil.transform
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-876?page=all ]
George Harley closed HARMONY-876.
---------------------------------
Verified by Richard.
> Refactor java.util.Formatter: FloatUtil.transform
> -------------------------------------------------
>
> Key: HARMONY-876
> URL: http://issues.apache.org/jira/browse/HARMONY-876
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Assigned To: George Harley
> Priority: Minor
> Attachments: luni.src.diff
>
>
> Hello,
> I try to refactor some code of java.util.Formatter which is related to FloatUtil.transform. I will attach the patch soon :-)
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-876) Refactor java.util.Formatter:
FloatUtil.transform
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-876?page=all ]
Richard Liang updated HARMONY-876:
----------------------------------
Attachment: luni.src.diff
Hello,
Would you please apply the patch soon? Thanks a lot.
Best regards,
Richard
> Refactor java.util.Formatter: FloatUtil.transform
> -------------------------------------------------
>
> Key: HARMONY-876
> URL: http://issues.apache.org/jira/browse/HARMONY-876
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Priority: Minor
> Attachments: luni.src.diff
>
>
> Hello,
> I try to refactor some code of java.util.Formatter which is related to FloatUtil.transform. I will attach the patch soon :-)
> Best regards,
> Richard
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira