svn commit: r1188809 - /incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/net/RegexURLFilter.java

[rf...@apache.org]

Author: rfrovarp
Date: Tue Oct 25 17:19:56 2011
New Revision: 1188809

URL: http://svn.apache.org/viewvc?rev=1188809&view=rev
Log:
Fixes DROIDS-150:
Closes InputStream
Fixed up Javadocs
Sets default capacities

Thanks to Tony Dietrich for the patch.

Modified:
    incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/net/RegexURLFilter.java

Modified: incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/net/RegexURLFilter.java
URL: http://svn.apache.org/viewvc/incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/net/RegexURLFilter.java?rev=1188809&r1=1188808&r2=1188809&view=diff
==============================================================================
--- incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/net/RegexURLFilter.java (original)
+++ incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/net/RegexURLFilter.java Tue Oct 25 17:19:56 2011
@@ -44,11 +44,13 @@ public class RegexURLFilter implements U
   private final List<RegexRule> rules;
   
   public RegexURLFilter(){
-    rules = new ArrayList< RegexRule >();
+    rules = new ArrayList< RegexRule >(16);
   }
   
   /**
    * Adds a new regex rule to this filter <br>
+   * @param sign
+   * @param regex 
    */
   public void addRule(final boolean sign, final String regex) {
     if( regex == null ){
@@ -78,6 +80,7 @@ public class RegexURLFilter implements U
   
   /**
    * @param file
+   * @throws IOException
    */
   public void setFile(String file) throws IOException {
     URL url = null;
@@ -89,11 +92,12 @@ public class RegexURLFilter implements U
     log.debug("url " + url);
     Reader reader = new InputStreamReader(url.openStream());
     rules.addAll( readRulesFile(reader) );
+    reader.close();
   }
 
   private List<RegexRule> readRulesFile(Reader reader) throws IOException {
     BufferedReader in = new BufferedReader(reader);
-    List<RegexRule> localRules = new ArrayList<RegexRule>();
+    List<RegexRule> localRules = new ArrayList<RegexRule>(16);
     String line = null;
 
     while ((line = in.readLine()) != null) {