You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2016/09/03 13:21:58 UTC

svn commit: r1759092 - /ofbiz/trunk/build.gradle

Author: jleroux
Date: Sat Sep  3 13:21:58 2016
New Revision: 1759092

URL: http://svn.apache.org/viewvc?rev=1759092&view=rev
Log:
Fixes both
"Character encoding issue found in file build.gradle" - https://issues.apache.org/jira/browse/OFBIZ-8119

I cann't build ofbiz when I run gradlew.
I found utf-8 should be the default character encoding used by the comipiling work.
eg.
def defaultEncoding = 'UTF-8'
tasks.withType(AbstractCompile)*.options*.encoding = defaultEncoding
tasks.withType(GroovyCompile)*.groovyOptions*.encoding = defaultEncoding

AND--------------------------------

"testFopMacroLibrary fails on Windows" - https://issues.apache.org/jira/browse/OFBIZ-7938

When running tests on Windows I get this error

Response contentType isn't good : text/html;charset=UTF-8 expected:<[application/pdf];charset=UTF-8> but was:<[text/html];charset=UTF-8>

junit.framework.ComparisonFailure: Response contentType isn't good : text/html;charset=UTF-8 expected:<[application/pdf];charset=UTF-8> but wwas:<[text/html];charset=UTF-8>
at org.apache.ofbiz.widget.test.WidgetMacroLibraryTests.testFopMacroLibrary(WidgetMacroLibraryTests.java:123)
at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.apache.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237)
at org.apache.ofbiz.base.start.StartupControlPanel.startStartupLoaders(StartupControlPanel.java:274)
at org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:73)
at org.apache.ofbiz.base.staart.Start.main(Start.java:84)


All tests pass on BuildBot.


Modified:
    ofbiz/trunk/build.gradle

Modified: ofbiz/trunk/build.gradle
URL: http://svn.apache.org/viewvc/ofbiz/trunk/build.gradle?rev=1759092&r1=1759091&r2=1759092&view=diff
==============================================================================
--- ofbiz/trunk/build.gradle (original)
+++ ofbiz/trunk/build.gradle Sat Sep  3 13:21:58 2016
@@ -716,6 +716,11 @@ tasks.addRule('Pattern: ofbizBackground
     }
 }
 
+// Enforces UTF-8 java compilation encoding on Windows platform
+tasks.withType(JavaCompile) {
+    options.encoding = 'UTF-8'
+}
+
 /* ========================================================
  * Helper Functions
  * ======================================================== */