You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2022/11/18 12:47:16 UTC
[GitHub] [mesos] yasiribmcon opened a new pull request, #449: Add s390x support for CI
yasiribmcon opened a new pull request, #449:
URL: https://github.com/apache/mesos/pull/449
Added support for **s390x** architecture by doing below mentioned changes :
- Added a new protobuf **patch** to support s390x builds.
- Updated grpc from 1.10.0 to **1.11.0** as the newer version has support for s390x(big-endian) machines.
- **Migrated** changes from grpc-1.10.0.patch to grpc-1.11.0.patch.
grpc 1.11.0 tar.gz has been created using below commands:
`git clone -b v1.11.0 https://github.com/grpc/grpc.git grpc-1.11.0
cd grpc-1.11.0/
git submodule update --init third_party/cares
cd ..
tar zcf grpc-1.11.0.tar.gz --exclude .git grpc-1.11.0 `
Also, **ubuntu-18.04-s390x.dockerfile** has been provided so that it can be used by Mesos CI to verify s390x builds.
We have run **mesos-build.sh**(which is also used by Mesos CI) and its passing for below configuration :
`BUILDTOOL=(cmake / autotools)
COMPILER=gcc
CONFIGURATION="--verbose --disable-libtool-wrappers --disable-parallel-test-execution"
ENVIRONMENT="GLOG_v=1 MESOS_VERBOSE=1 MESOS_TEST_AWAIT_TIMEOUT=60secs"`
Note : Only one test case _DockerFetcherPluginTest.INTERNET_CURL_FetchBlob_ is failing for both intel(amd64) and s390x as its referring to a private registry **registry-1.docker.io**, so this test case should pass when it gets run from Mesos CI.
CI logs :
Autotools : [ci_autotools_gcc_s390x.zip](https://github.com/apache/mesos/files/10041338/ci_autotools_gcc_s390x.zip)
Cmake : [ci_cmake_gcc_s390x.zip](https://github.com/apache/mesos/files/10041341/ci_cmake_gcc_s390x.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] yasiribmcon commented on pull request #449: Add s390x support for CI
Posted by GitBox <gi...@apache.org>.
yasiribmcon commented on PR #449:
URL: https://github.com/apache/mesos/pull/449#issuecomment-1329314819
Discarded old commit which caused the PR to auto-close.
Reopening PR with rest of the changes!
We have added a new protobuf patch to support s390x builds.
ubuntu-18.04-s390x.dockerfile has been provided so that it can be used by Mesos CI to verify s390x builds.
Please do let us know if you require anything else from our side to enable s390x CI for Mesos.
Intel/S390X CI logs with Protobuf patch : [CI_Logs_Protobuf_Patch.zip](https://github.com/apache/mesos/files/10105202/CI_Logs_Protobuf_Patch.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] yasiribmcon commented on pull request #449: Add s390x support for CI
Posted by "yasiribmcon (via GitHub)" <gi...@apache.org>.
yasiribmcon commented on PR #449:
URL: https://github.com/apache/mesos/pull/449#issuecomment-1400292700
Hi @cf-natali ,
Gentle reminder on my above mentioned query regarding enabling Mesos CI for s390x architecture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] yasiribmcon commented on pull request #449: Add s390x support for CI
Posted by GitBox <gi...@apache.org>.
yasiribmcon commented on PR #449:
URL: https://github.com/apache/mesos/pull/449#issuecomment-1323486831
Sure @cf-natali.
Will create a separate PR for grpc update.
Changes for s390x support were available in 1.11.0, so we went for the same version as candidate version.
Will now test on grpc 1.11.1 and submit PR once testing is green from our side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] yasiribmcon commented on pull request #449: Add s390x support for CI
Posted by "yasiribmcon (via GitHub)" <gi...@apache.org>.
yasiribmcon commented on PR #449:
URL: https://github.com/apache/mesos/pull/449#issuecomment-1507977986
Hi @cf-natali ,
Gentle reminder for enabling Mesos CI for s390 architechture.
Do let me know if you require anything from my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] yasiribmcon closed pull request #449: Add s390x support for CI
Posted by GitBox <gi...@apache.org>.
yasiribmcon closed pull request #449: Add s390x support for CI
URL: https://github.com/apache/mesos/pull/449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali merged pull request #449: Add s390x support for CI
Posted by GitBox <gi...@apache.org>.
cf-natali merged PR #449:
URL: https://github.com/apache/mesos/pull/449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali commented on pull request #449: Add s390x support for CI
Posted by GitBox <gi...@apache.org>.
cf-natali commented on PR #449:
URL: https://github.com/apache/mesos/pull/449#issuecomment-1363284098
@yasiribmcon , thanks for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] yasiribmcon commented on pull request #449: Add s390x support for CI
Posted by GitBox <gi...@apache.org>.
yasiribmcon commented on PR #449:
URL: https://github.com/apache/mesos/pull/449#issuecomment-1363680253
Thanks @cf-natali !
Since mesos should run fine on s390x now, could you please enable s390x job in [Mesos CI](https://builds.apache.org/job/Mesos/).
Configuration and s390x nodes are already mentioned in my first post and [dockerfile](https://github.com/apache/mesos/tree/master/support/mesos-build) is available as well.
Please do let me know if anything is required from my side or if I should contact someone else to enable Mesos CI for s390x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali commented on pull request #449: Add s390x support for CI
Posted by GitBox <gi...@apache.org>.
cf-natali commented on PR #449:
URL: https://github.com/apache/mesos/pull/449#issuecomment-1321100227
Thanks!
Would it be possible to submit the grpc update in its own PR?
Also, any reason to select grpc 1.11.0 instead of 1.11.1 (point release)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org