You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/03/26 23:49:32 UTC

Re: Review Request: New scheduler callbacks for accessing master information

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/
-----------------------------------------------------------

(Updated 2012-03-26 21:49:32.063624)


Review request for mesos, Benjamin Hindman and John Sirois.


Changes
-------

merged with the latest trunk


Summary
-------

    New Scheduler callbacks for master info (ip and port)
    
    --> registered() callback now includes maste info 
    --> new re-registered() callback is called when a new master is elected
    --> new masterLost() callback is called when mesos core doesnt detect an
    active master (e.g: during election)


This addresses bug MESOS-86.
    https://issues.apache.org/jira/browse/MESOS-86


Diffs (updated)
-----

  include/mesos/scheduler.hpp 5bcf065 
  src/examples/java/TestExceptionFramework.java d15b132 
  src/examples/java/TestFramework.java f86646b 
  src/examples/java/TestMultipleExecutorsFramework.java cdbcc48 
  src/examples/long_lived_framework.cpp 2775f5a 
  src/examples/no_executor_framework.cpp fb31b25 
  src/examples/python/test_framework.py 0d71831 
  src/examples/test_framework.cpp 622f6ac 
  src/java/jni/convert.cpp 5c2bf21 
  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 547d54b 
  src/java/src/org/apache/mesos/Scheduler.java b01468b 
  src/master/master.cpp 6110c17 
  src/messages/messages.proto 7f9cffe 
  src/python/native/proxy_scheduler.hpp d0e5dfd 
  src/python/native/proxy_scheduler.cpp 9717f44 
  src/python/src/mesos.py 25d762b 
  src/sched/sched.cpp 9440381 
  src/tests/exception_tests.cpp c14bacc 
  src/tests/fault_tolerance_tests.cpp 9e7d181 
  src/tests/master_tests.cpp 57db468 
  src/tests/resource_offers_tests.cpp a405888 
  src/tests/utils.hpp 9241567 

Diff: https://reviews.apache.org/r/3083/diff


Testing
-------

./bin/tests/all-tests


Thanks,

Vinod

Re: Review Request: New Scheduler and Executor callbacks

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/
-----------------------------------------------------------

(Updated 2012-03-27 07:06:42.783287)


Review request for mesos, Benjamin Hindman and John Sirois.


Changes
-------

new executor registered and reregistered callbacks.


Summary
-------

    New Scheduler callbacks for master info (ip and port)
    
    --> registered() callback now includes maste info 
    --> new re-registered() callback is called when a new master is elected
    --> new masterLost() callback is called when mesos core doesnt detect an
    active master (e.g: during election)
   --> new executorLost() callback

New Executor callbacks
 --> reregistered() callback
--> slaveLost() callback


This addresses bug MESOS-86.
    https://issues.apache.org/jira/browse/MESOS-86


Diffs (updated)
-----

  include/mesos/executor.hpp ef7bdf9 
  include/mesos/mesos.proto 23aad17 
  include/mesos/scheduler.hpp 5bcf065 
  src/common/values.cpp 09d162f 
  src/examples/java/TestExceptionFramework.java d15b132 
  src/examples/java/TestExecutor.java f57cda4 
  src/examples/java/TestFramework.java f86646b 
  src/examples/java/TestMultipleExecutorsFramework.java cdbcc48 
  src/examples/long_lived_executor.cpp 4b4abad 
  src/examples/long_lived_framework.cpp 2775f5a 
  src/examples/no_executor_framework.cpp fb31b25 
  src/examples/python/test_framework.py 0d71831 
  src/examples/test_executor.cpp ba54004 
  src/examples/test_framework.cpp 622f6ac 
  src/exec/exec.cpp 060707ad 
  src/java/jni/convert.cpp 5c2bf21 
  src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 579ebbe 
  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 547d54b 
  src/java/src/org/apache/mesos/Executor.java 3db3068 
  src/java/src/org/apache/mesos/MesosSchedulerDriver.java 129a108 
  src/java/src/org/apache/mesos/Scheduler.java b01468b 
  src/java/src/org/apache/mesos/SchedulerDriver.java 0638ee3 
  src/launcher/executor.cpp da4203c 
  src/master/master.cpp 6110c17 
  src/messages/messages.proto 7f9cffe 
  src/python/native/mesos_scheduler_driver_impl.cpp 9e088ef 
  src/python/native/proxy_executor.hpp 32df90b 
  src/python/native/proxy_executor.cpp d453406 
  src/python/native/proxy_scheduler.hpp d0e5dfd 
  src/python/native/proxy_scheduler.cpp 9717f44 
  src/python/src/mesos.py 25d762b 
  src/scaling/nested_exec.py 9625953 
  src/sched/sched.cpp 9440381 
  src/tests/exception_tests.cpp c14bacc 
  src/tests/fault_tolerance_tests.cpp 9e7d181 
  src/tests/master_tests.cpp 57db468 
  src/tests/resource_offers_tests.cpp a405888 
  src/tests/utils.hpp 9241567 

Diff: https://reviews.apache.org/r/3083/diff


Testing (updated)
-------

make check success except PythonFramework test


Thanks,

Vinod

Re: Review Request: New Scheduler and Executor callbacks

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/
-----------------------------------------------------------

(Updated 2012-03-27 05:39:13.559518)


Review request for mesos, Benjamin Hindman and John Sirois.


Changes
-------

swapped the arguments of frameworkmessage and sendframeworkmessage to be consistent.

added an optional SlaveID field to SlaveInfo


Summary
-------

    New Scheduler callbacks for master info (ip and port)
    
    --> registered() callback now includes maste info 
    --> new re-registered() callback is called when a new master is elected
    --> new masterLost() callback is called when mesos core doesnt detect an
    active master (e.g: during election)
   --> new executorLost() callback

New Executor callbacks
 --> reregistered() callback
--> slaveLost() callback


This addresses bug MESOS-86.
    https://issues.apache.org/jira/browse/MESOS-86


Diffs (updated)
-----

  include/mesos/executor.hpp ef7bdf9 
  include/mesos/mesos.proto 23aad17 
  include/mesos/scheduler.hpp 5bcf065 
  src/common/values.cpp 09d162f 
  src/examples/java/TestExceptionFramework.java d15b132 
  src/examples/java/TestFramework.java f86646b 
  src/examples/java/TestMultipleExecutorsFramework.java cdbcc48 
  src/examples/long_lived_executor.cpp 4b4abad 
  src/examples/long_lived_framework.cpp 2775f5a 
  src/examples/no_executor_framework.cpp fb31b25 
  src/examples/python/test_framework.py 0d71831 
  src/examples/test_executor.cpp ba54004 
  src/examples/test_framework.cpp 622f6ac 
  src/exec/exec.cpp 060707ad 
  src/java/jni/convert.cpp 5c2bf21 
  src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 579ebbe 
  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 547d54b 
  src/java/src/org/apache/mesos/MesosSchedulerDriver.java 129a108 
  src/java/src/org/apache/mesos/Scheduler.java b01468b 
  src/java/src/org/apache/mesos/SchedulerDriver.java 0638ee3 
  src/launcher/executor.cpp da4203c 
  src/master/master.cpp 6110c17 
  src/messages/messages.proto 7f9cffe 
  src/python/native/mesos_scheduler_driver_impl.cpp 9e088ef 
  src/python/native/proxy_executor.hpp 32df90b 
  src/python/native/proxy_executor.cpp d453406 
  src/python/native/proxy_scheduler.hpp d0e5dfd 
  src/python/native/proxy_scheduler.cpp 9717f44 
  src/python/src/mesos.py 25d762b 
  src/sched/sched.cpp 9440381 
  src/tests/exception_tests.cpp c14bacc 
  src/tests/fault_tolerance_tests.cpp 9e7d181 
  src/tests/master_tests.cpp 57db468 
  src/tests/resource_offers_tests.cpp a405888 
  src/tests/utils.hpp 9241567 

Diff: https://reviews.apache.org/r/3083/diff


Testing
-------

make check


Thanks,

Vinod

Re: Review Request: New Scheduler and Executor callbacks

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/#review6395
-----------------------------------------------------------

Ship it!


Thanks Vinod! I know Matei really wanted these in before the release so this is great!


src/examples/java/TestExceptionFramework.java
<https://reviews.apache.org/r/3083/#comment13955>

    Wrap.



src/examples/java/TestFramework.java
<https://reviews.apache.org/r/3083/#comment13956>

    Wrap.



src/examples/java/TestMultipleExecutorsFramework.java
<https://reviews.apache.org/r/3083/#comment13957>

    Wrap.



src/examples/long_lived_framework.cpp
<https://reviews.apache.org/r/3083/#comment13952>

    Don't you want to reorganize these? ;) (And elsewhere.)



src/examples/no_executor_framework.cpp
<https://reviews.apache.org/r/3083/#comment13953>

    Awesome!



src/java/jni/convert.cpp
<https://reviews.apache.org/r/3083/#comment13958>

    Not used, please kill.



src/java/src/org/apache/mesos/Scheduler.java
<https://reviews.apache.org/r/3083/#comment13959>

    Put on previous line.



src/python/native/proxy_scheduler.cpp
<https://reviews.apache.org/r/3083/#comment13960>

    Ugh. ;)



src/python/native/proxy_scheduler.cpp
<https://reviews.apache.org/r/3083/#comment13961>

    Indentation.


- Benjamin


On 2012-03-27 01:25:17, Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3083/
> -----------------------------------------------------------
> 
> (Updated 2012-03-27 01:25:17)
> 
> 
> Review request for mesos, Benjamin Hindman and John Sirois.
> 
> 
> Summary
> -------
> 
>     New Scheduler callbacks for master info (ip and port)
>     
>     --> registered() callback now includes maste info 
>     --> new re-registered() callback is called when a new master is elected
>     --> new masterLost() callback is called when mesos core doesnt detect an
>     active master (e.g: during election)
>    --> new executorLost() callback
> 
> New Executor callbacks
>  --> reregistered() callback
> --> slaveLost() callback
> 
> 
> This addresses bug MESOS-86.
>     https://issues.apache.org/jira/browse/MESOS-86
> 
> 
> Diffs
> -----
> 
>   include/mesos/executor.hpp ef7bdf9 
>   include/mesos/scheduler.hpp 5bcf065 
>   src/common/values.cpp 09d162f 
>   src/examples/java/TestExceptionFramework.java d15b132 
>   src/examples/java/TestFramework.java f86646b 
>   src/examples/java/TestMultipleExecutorsFramework.java cdbcc48 
>   src/examples/long_lived_executor.cpp 4b4abad 
>   src/examples/long_lived_framework.cpp 2775f5a 
>   src/examples/no_executor_framework.cpp fb31b25 
>   src/examples/python/test_framework.py 0d71831 
>   src/examples/test_executor.cpp ba54004 
>   src/examples/test_framework.cpp 622f6ac 
>   src/java/jni/convert.cpp 5c2bf21 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 579ebbe 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 547d54b 
>   src/java/src/org/apache/mesos/Scheduler.java b01468b 
>   src/launcher/executor.cpp da4203c 
>   src/master/master.cpp 6110c17 
>   src/messages/messages.proto 7f9cffe 
>   src/python/native/proxy_executor.hpp 32df90b 
>   src/python/native/proxy_executor.cpp d453406 
>   src/python/native/proxy_scheduler.hpp d0e5dfd 
>   src/python/native/proxy_scheduler.cpp 9717f44 
>   src/python/src/mesos.py 25d762b 
>   src/sched/sched.cpp 9440381 
>   src/tests/exception_tests.cpp c14bacc 
>   src/tests/fault_tolerance_tests.cpp 9e7d181 
>   src/tests/master_tests.cpp 57db468 
>   src/tests/resource_offers_tests.cpp a405888 
>   src/tests/utils.hpp 9241567 
> 
> Diff: https://reviews.apache.org/r/3083/diff
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod
> 
>

Re: Review Request: New Scheduler and Executor callbacks

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/
-----------------------------------------------------------

(Updated 2012-03-27 01:25:17.748670)


Review request for mesos, Benjamin Hindman and John Sirois.


Changes
-------

changed title


Summary (updated)
-------

    New Scheduler callbacks for master info (ip and port)
    
    --> registered() callback now includes maste info 
    --> new re-registered() callback is called when a new master is elected
    --> new masterLost() callback is called when mesos core doesnt detect an
    active master (e.g: during election)
   --> new executorLost() callback

New Executor callbacks
 --> reregistered() callback
--> slaveLost() callback


This addresses bug MESOS-86.
    https://issues.apache.org/jira/browse/MESOS-86


Diffs
-----

  include/mesos/executor.hpp ef7bdf9 
  include/mesos/scheduler.hpp 5bcf065 
  src/common/values.cpp 09d162f 
  src/examples/java/TestExceptionFramework.java d15b132 
  src/examples/java/TestFramework.java f86646b 
  src/examples/java/TestMultipleExecutorsFramework.java cdbcc48 
  src/examples/long_lived_executor.cpp 4b4abad 
  src/examples/long_lived_framework.cpp 2775f5a 
  src/examples/no_executor_framework.cpp fb31b25 
  src/examples/python/test_framework.py 0d71831 
  src/examples/test_executor.cpp ba54004 
  src/examples/test_framework.cpp 622f6ac 
  src/java/jni/convert.cpp 5c2bf21 
  src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 579ebbe 
  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 547d54b 
  src/java/src/org/apache/mesos/Scheduler.java b01468b 
  src/launcher/executor.cpp da4203c 
  src/master/master.cpp 6110c17 
  src/messages/messages.proto 7f9cffe 
  src/python/native/proxy_executor.hpp 32df90b 
  src/python/native/proxy_executor.cpp d453406 
  src/python/native/proxy_scheduler.hpp d0e5dfd 
  src/python/native/proxy_scheduler.cpp 9717f44 
  src/python/src/mesos.py 25d762b 
  src/sched/sched.cpp 9440381 
  src/tests/exception_tests.cpp c14bacc 
  src/tests/fault_tolerance_tests.cpp 9e7d181 
  src/tests/master_tests.cpp 57db468 
  src/tests/resource_offers_tests.cpp a405888 
  src/tests/utils.hpp 9241567 

Diff: https://reviews.apache.org/r/3083/diff


Testing
-------

make check


Thanks,

Vinod

Re: Review Request: New scheduler callbacks for accessing master information

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/
-----------------------------------------------------------

(Updated 2012-03-27 01:24:56.797946)


Review request for mesos, Benjamin Hindman and John Sirois.


Changes
-------

added new callbacks to scheduler and executor.


Summary (updated)
-------

    New Scheduler callbacks for master info (ip and port)
    
    --> registered() callback now includes maste info 
    --> new re-registered() callback is called when a new master is elected
    --> new masterLost() callback is called when mesos core doesnt detect an
    active master (e.g: during election)
   --> new executorLost() callback

New Executor callbacks
 --> reregistered() callback
--> slaveLost() callback


This addresses bug MESOS-86.
    https://issues.apache.org/jira/browse/MESOS-86


Diffs (updated)
-----

  include/mesos/executor.hpp ef7bdf9 
  include/mesos/scheduler.hpp 5bcf065 
  src/common/values.cpp 09d162f 
  src/examples/java/TestExceptionFramework.java d15b132 
  src/examples/java/TestFramework.java f86646b 
  src/examples/java/TestMultipleExecutorsFramework.java cdbcc48 
  src/examples/long_lived_executor.cpp 4b4abad 
  src/examples/long_lived_framework.cpp 2775f5a 
  src/examples/no_executor_framework.cpp fb31b25 
  src/examples/python/test_framework.py 0d71831 
  src/examples/test_executor.cpp ba54004 
  src/examples/test_framework.cpp 622f6ac 
  src/java/jni/convert.cpp 5c2bf21 
  src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 579ebbe 
  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 547d54b 
  src/java/src/org/apache/mesos/Scheduler.java b01468b 
  src/launcher/executor.cpp da4203c 
  src/master/master.cpp 6110c17 
  src/messages/messages.proto 7f9cffe 
  src/python/native/proxy_executor.hpp 32df90b 
  src/python/native/proxy_executor.cpp d453406 
  src/python/native/proxy_scheduler.hpp d0e5dfd 
  src/python/native/proxy_scheduler.cpp 9717f44 
  src/python/src/mesos.py 25d762b 
  src/sched/sched.cpp 9440381 
  src/tests/exception_tests.cpp c14bacc 
  src/tests/fault_tolerance_tests.cpp 9e7d181 
  src/tests/master_tests.cpp 57db468 
  src/tests/resource_offers_tests.cpp a405888 
  src/tests/utils.hpp 9241567 

Diff: https://reviews.apache.org/r/3083/diff


Testing (updated)
-------

make check


Thanks,

Vinod