[GitHub] [calcite] danny0405 commented on a change in pull request #1309: [CALCITE-3183] Trimming method for Filter rel uses wrong traitSet

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #1309: [CALCITE-3183] Trimming method for Filter rel uses wrong traitSet
URL: https://github.com/apache/calcite/pull/1309#discussion_r301855155
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
 ##########
 @@ -1146,16 +1146,18 @@ public RelBuilder functionScan(SqlOperator operator,
    * and optimized in a similar way to the {@link #and} method.
    * If the result is TRUE no filter is created. */
   public RelBuilder filter(RexNode... predicates) {
-    return filter(ImmutableList.copyOf(predicates));
+    return filter(Collections.emptyList(), ImmutableList.copyOf(predicates));
   }
 
-  /** Creates a {@link Filter} of a list of
-   * predicates.
+  /**
+   * Creates a {@link Filter} of a list of
+   * predicates and correlation variables
    *
    * <p>The predicates are combined using AND,
    * and optimized in a similar way to the {@link #and} method.
    * If the result is TRUE no filter is created. */
-  public RelBuilder filter(Iterable<? extends RexNode> predicates) {
+  public RelBuilder filter(Iterable<CorrelationId> correlVariables,
+      Iterable<? extends RexNode> predicates) {
 
 Review comment:
   Can we always keep the `correlVariables` as the last argument ? Just like the `FilterFactory`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services