You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/27 09:37:15 UTC

[GitHub] [doris] carlvinhust2012 opened a new pull request, #13731: [optimization](array-type) update the exception message when create t…

carlvinhust2012 opened a new pull request, #13731:
URL: https://github.com/apache/doris/pull/13731

   # Proposed changes
   1. this pr is used to update the exception message when create table with array column.
   
   2. before the change, we run "CREATE TABLE" will get the Inaccurate error message.
   MySQL [example_db]> CREATE TABLE array_test_problem108 ( k2 ARRAY<INT> NOT NULL, k1 INT NOT NULL )  DISTRIBUTED BY HASH(k1) BUCKETS 1;
   ERROR 1105 (HY000): errCode = 2, detailMessage = The olap table first column could not be float, double, string or array, please use decimal or varchar instead.
   
   3. after the change, we run "CREATE TABLE" will get the accurate error message.
   MySQL [example_db]> CREATE TABLE array_test_problem108 ( k2 ARRAY<INT> NOT NULL, k1 INT NOT NULL )  DISTRIBUTED BY HASH(k1) BUCKETS 1;
   ERROR 1105 (HY000): errCode = 2, detailMessage = The olap table first column could not be float, double, string or array, please use decimal or varchar instead.
   
   Issue Number: #7570
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   5. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   6. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   7. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   8. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #13731: [optimization](array-type) update the exception message when create t…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13731:
URL: https://github.com/apache/doris/pull/13731#issuecomment-1293712942

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hello-stephen commented on pull request #13731: [optimization](array-type) update the exception message when create t…

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13731:
URL: https://github.com/apache/doris/pull/13731#issuecomment-1294333740

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 38.86 seconds
    load time: 563 seconds
    storage size: 17154810463 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221028015946_clickbench_pr_34999.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] xy720 merged pull request #13731: [optimization](array-type) update the exception message when create t…

Posted by GitBox <gi...@apache.org>.
xy720 merged PR #13731:
URL: https://github.com/apache/doris/pull/13731


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hello-stephen commented on pull request #13731: [optimization](array-type) update the exception message when create t…

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13731:
URL: https://github.com/apache/doris/pull/13731#issuecomment-1293424608

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 38.42 seconds
    load time: 568 seconds
    storage size: 17154655330 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221027200329_clickbench_pr_34817.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #13731: [optimization](array-type) update the exception message when create t…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13731:
URL: https://github.com/apache/doris/pull/13731#issuecomment-1293365671

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #13731: [optimization](array-type) update the exception message when create t…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13731:
URL: https://github.com/apache/doris/pull/13731#issuecomment-1293365771

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org