You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Volkan Yazıcı <vo...@gmail.com> on 2020/03/04 11:51:52 UTC
unstable master branch
Hello,
While developing it is really difficult to keep up with the master
branch, it continuously gets broken. master and release-2.x diverge a
lot as well, hence I am sitting on the fence for whether I should base
my changes on master or release-2.x. This is my current state:
$ git remote -v
origin git@github.com:vy/log4j2.git (fetch)
origin git@github.com:vy/log4j2.git (push)
upstream https://github.com/apache/logging-log4j2.git (fetch)
upstream https://github.com/apache/logging-log4j2.git (push)
$ git fetch -pP upstream
$ git rebase upstream/master
Current branch master is up to date.
$ git diff master..upstream/master
$ rm -rf ~/.m2/repository/org/apache/logging
$ ./mvnw clean package -Dmaven.test.skip=true
...
[ERROR] Failed to execute goal on project log4j-plugins: Could not
resolve dependencies for project
org.apache.logging.log4j:log4j-plugins:jar:3.0.0-SNAPSHOT: Could not
find artifact org.apache.logging.log4j:log4j-api:jar:tests:3.0.0-SNAPSHOT
I have checked Travis[1] and Jenkins[2], their end doesn't look bright either.
How do you people deal with this? How do you develop? Which branch
shall I use to base JsonTemplateLayout?
Kind regards.
[1] https://travis-ci.org/apache/logging-log4j2/builds
[2] https://builds.apache.org/view/L/view/Logging/
Re: unstable master branch
Posted by Ralph Goers <ra...@dslextreme.com>.
The Jenkins build of master is now working on Windows. It seems ResolverUtil had a bug that I fixed on the release-2.x branch last year but forgot to migrate to master. That fix has now been applied.
Ralph
> On Mar 6, 2020, at 8:48 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>
> I compile master several times a day on MacOS without problems. Jenkins shows a single test failing on Windows. I have determined that there is one test method that is not properly closing a stream and is preventing a file from being deleted but I have not yet located the code that is causing that problem. Other than that I am not aware of any problems in master.
>
> I have never seen the “Could not resolve dependencies for project” error referencing the log4j-api test jar.
>
> Ralph
>
>> On Mar 6, 2020, at 2:49 AM, Volkan Yazıcı <vo...@gmail.com> wrote:
>>
>> I am pretty confident that the "master" is broken:
>>
>> $ /home/vy/Software/share/java/jdk/8/bin/java -version
>> openjdk version "1.8.0_232"
>> OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_232-b09)
>> OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.232-b09, mixed mode)
>>
>> $ /home/vy/Software/share/java/jdk/11/bin/java -version
>> openjdk version "11.0.2" 2019-01-15
>> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.2+9)
>> OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.2+9, mixed mode)
>>
>> $ docker run -it \
>> -v $HOME/.m2:/root/.m2 \
>> -v /home/vy/Projects/log4j2:/log4j2 \
>> -v /home/vy/Software/share/java/jdk/8:/home/vy/Software/share/java/jdk/8 \
>> -v /home/vy/Software/share/java/jdk/11:/home/vy/Software/share/java/jdk/11 \
>> adoptopenjdk/openjdk8:latest \
>> /bin/bash
>>
>> # cd /log4j2
>> # ./mvnw clean package -Dmaven.test.skip=true
>>
>> These combinations produce exactly the same error I shared earlier.
>>
>> I will really appreciate some help. I am done with my single-file
>> simple JSON parser[1]. But since I am not able to compile the project
>> anymore, I cannot proceed with incorporating the last bit of changes
>> to remove the Jackson dependency.
>>
>> Kind regards.
>>
>> [1] https://gist.github.com/vy/a8018bbdf5442e998f95008f5959e775
>>
>> On Thu, Mar 5, 2020 at 4:34 PM Volkan Yazıcı <vo...@gmail.com> wrote:
>>>
>>> Nope, neither "install" works; fails with the same message.
>>>
>>> On Thu, Mar 5, 2020 at 4:25 PM Matt Sicker <bo...@gmail.com> wrote:
>>>>
>>>> It could be an issue in the pom somewhere. Does "install" instead of
>>>> "package" work for you?
>>>>
>>>> On Thu, 5 Mar 2020 at 02:27, Volkan Yazıcı <vo...@gmail.com> wrote:
>>>>>
>>>>> Even after a clean checkout:
>>>>>
>>>>> $ cd /tmp
>>>>> $ git clone https://github.com/apache/logging-log4j2.git log4j2
>>>>> $ cd log4j2
>>>>> $ m -rf ~/.m2/repository/org/apache/logging
>>>>> $ ./mvnw package -Dmaven.test.skip=true
>>>>>
>>>>> I still get the very same error. I see that Jenkins is still failing,
>>>>> though Travis has recovered yesterday after a change of yours. What
>>>>> might I be missing? How can I further debug the problem?
>>>>>
>>>>> On Wed, Mar 4, 2020 at 5:11 PM Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>
>>>>>> My typical development follow 1 of 2 paths.
>>>>>>
>>>>>> 1. I am doing a patch or new feature targeted at the 2.x release train. I do my initial development on the release-2.x branch. Once it is fully tested I cherry-pick it (when possible) to the master branch. If I can’t cherry-pick it I manually copy the changes. For both release-2.x and master I ALWAYS run full builds before committing. I only run the builds on Mac OS.
>>>>>> 2. I am creating a patch or new feature only targeted at master. I do all my development and testing on master. I ALWAYS run a full build before committing. I only run the builds on Mac OS.
>>>>>>
>>>>>> Frequently I notice that the Jenkins builds on Windows fail. I recently fixed the bad tests on the release-2.x branch as I don’t want to cut a release knowing there are failing unit tests. Since we have no plans to cut a 3.0 release soon I haven’t worried about Windows too much since, while I find the emails annoying, they aren’t blocking me.
>>>>>>
>>>>>> I can’t recall ever seeing the error below. It implies that the log4j-plugins module is being built before the log4j-api module, which never happens for me. I suppose it would happen if you try to build the log4j-plugin module from its directory without having built the rest of log4j.
>>>>>>
>>>>>> Ralph
>>>>>>
>>>>>>> On Mar 4, 2020, at 4:51 AM, Volkan Yazıcı <vo...@gmail.com> wrote:
>>>>>>>
>>>>>>> Hello,
>>>>>>>
>>>>>>> While developing it is really difficult to keep up with the master
>>>>>>> branch, it continuously gets broken. master and release-2.x diverge a
>>>>>>> lot as well, hence I am sitting on the fence for whether I should base
>>>>>>> my changes on master or release-2.x. This is my current state:
>>>>>>>
>>>>>>> $ git remote -v
>>>>>>> origin git@github.com:vy/log4j2.git (fetch)
>>>>>>> origin git@github.com:vy/log4j2.git (push)
>>>>>>> upstream https://github.com/apache/logging-log4j2.git (fetch)
>>>>>>> upstream https://github.com/apache/logging-log4j2.git (push)
>>>>>>> $ git fetch -pP upstream
>>>>>>> $ git rebase upstream/master
>>>>>>> Current branch master is up to date.
>>>>>>> $ git diff master..upstream/master
>>>>>>> $ rm -rf ~/.m2/repository/org/apache/logging
>>>>>>> $ ./mvnw clean package -Dmaven.test.skip=true
>>>>>>> ...
>>>>>>> [ERROR] Failed to execute goal on project log4j-plugins: Could not
>>>>>>> resolve dependencies for project
>>>>>>> org.apache.logging.log4j:log4j-plugins:jar:3.0.0-SNAPSHOT: Could not
>>>>>>> find artifact org.apache.logging.log4j:log4j-api:jar:tests:3.0.0-SNAPSHOT
>>>>>>>
>>>>>>> I have checked Travis[1] and Jenkins[2], their end doesn't look bright either.
>>>>>>>
>>>>>>> How do you people deal with this? How do you develop? Which branch
>>>>>>> shall I use to base JsonTemplateLayout?
>>>>>>>
>>>>>>> Kind regards.
>>>>>>>
>>>>>>> [1] https://travis-ci.org/apache/logging-log4j2/builds
>>>>>>> [2] https://builds.apache.org/view/L/view/Logging/
>>>>>>>
>>>>>>
>>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Matt Sicker <bo...@gmail.com>
>>
>
>
>
Re: unstable master branch
Posted by Ralph Goers <ra...@dslextreme.com>.
I compile master several times a day on MacOS without problems. Jenkins shows a single test failing on Windows. I have determined that there is one test method that is not properly closing a stream and is preventing a file from being deleted but I have not yet located the code that is causing that problem. Other than that I am not aware of any problems in master.
I have never seen the “Could not resolve dependencies for project” error referencing the log4j-api test jar.
Ralph
> On Mar 6, 2020, at 2:49 AM, Volkan Yazıcı <vo...@gmail.com> wrote:
>
> I am pretty confident that the "master" is broken:
>
> $ /home/vy/Software/share/java/jdk/8/bin/java -version
> openjdk version "1.8.0_232"
> OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_232-b09)
> OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.232-b09, mixed mode)
>
> $ /home/vy/Software/share/java/jdk/11/bin/java -version
> openjdk version "11.0.2" 2019-01-15
> OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.2+9)
> OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.2+9, mixed mode)
>
> $ docker run -it \
> -v $HOME/.m2:/root/.m2 \
> -v /home/vy/Projects/log4j2:/log4j2 \
> -v /home/vy/Software/share/java/jdk/8:/home/vy/Software/share/java/jdk/8 \
> -v /home/vy/Software/share/java/jdk/11:/home/vy/Software/share/java/jdk/11 \
> adoptopenjdk/openjdk8:latest \
> /bin/bash
>
> # cd /log4j2
> # ./mvnw clean package -Dmaven.test.skip=true
>
> These combinations produce exactly the same error I shared earlier.
>
> I will really appreciate some help. I am done with my single-file
> simple JSON parser[1]. But since I am not able to compile the project
> anymore, I cannot proceed with incorporating the last bit of changes
> to remove the Jackson dependency.
>
> Kind regards.
>
> [1] https://gist.github.com/vy/a8018bbdf5442e998f95008f5959e775
>
> On Thu, Mar 5, 2020 at 4:34 PM Volkan Yazıcı <vo...@gmail.com> wrote:
>>
>> Nope, neither "install" works; fails with the same message.
>>
>> On Thu, Mar 5, 2020 at 4:25 PM Matt Sicker <bo...@gmail.com> wrote:
>>>
>>> It could be an issue in the pom somewhere. Does "install" instead of
>>> "package" work for you?
>>>
>>> On Thu, 5 Mar 2020 at 02:27, Volkan Yazıcı <vo...@gmail.com> wrote:
>>>>
>>>> Even after a clean checkout:
>>>>
>>>> $ cd /tmp
>>>> $ git clone https://github.com/apache/logging-log4j2.git log4j2
>>>> $ cd log4j2
>>>> $ m -rf ~/.m2/repository/org/apache/logging
>>>> $ ./mvnw package -Dmaven.test.skip=true
>>>>
>>>> I still get the very same error. I see that Jenkins is still failing,
>>>> though Travis has recovered yesterday after a change of yours. What
>>>> might I be missing? How can I further debug the problem?
>>>>
>>>> On Wed, Mar 4, 2020 at 5:11 PM Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>
>>>>> My typical development follow 1 of 2 paths.
>>>>>
>>>>> 1. I am doing a patch or new feature targeted at the 2.x release train. I do my initial development on the release-2.x branch. Once it is fully tested I cherry-pick it (when possible) to the master branch. If I can’t cherry-pick it I manually copy the changes. For both release-2.x and master I ALWAYS run full builds before committing. I only run the builds on Mac OS.
>>>>> 2. I am creating a patch or new feature only targeted at master. I do all my development and testing on master. I ALWAYS run a full build before committing. I only run the builds on Mac OS.
>>>>>
>>>>> Frequently I notice that the Jenkins builds on Windows fail. I recently fixed the bad tests on the release-2.x branch as I don’t want to cut a release knowing there are failing unit tests. Since we have no plans to cut a 3.0 release soon I haven’t worried about Windows too much since, while I find the emails annoying, they aren’t blocking me.
>>>>>
>>>>> I can’t recall ever seeing the error below. It implies that the log4j-plugins module is being built before the log4j-api module, which never happens for me. I suppose it would happen if you try to build the log4j-plugin module from its directory without having built the rest of log4j.
>>>>>
>>>>> Ralph
>>>>>
>>>>>> On Mar 4, 2020, at 4:51 AM, Volkan Yazıcı <vo...@gmail.com> wrote:
>>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> While developing it is really difficult to keep up with the master
>>>>>> branch, it continuously gets broken. master and release-2.x diverge a
>>>>>> lot as well, hence I am sitting on the fence for whether I should base
>>>>>> my changes on master or release-2.x. This is my current state:
>>>>>>
>>>>>> $ git remote -v
>>>>>> origin git@github.com:vy/log4j2.git (fetch)
>>>>>> origin git@github.com:vy/log4j2.git (push)
>>>>>> upstream https://github.com/apache/logging-log4j2.git (fetch)
>>>>>> upstream https://github.com/apache/logging-log4j2.git (push)
>>>>>> $ git fetch -pP upstream
>>>>>> $ git rebase upstream/master
>>>>>> Current branch master is up to date.
>>>>>> $ git diff master..upstream/master
>>>>>> $ rm -rf ~/.m2/repository/org/apache/logging
>>>>>> $ ./mvnw clean package -Dmaven.test.skip=true
>>>>>> ...
>>>>>> [ERROR] Failed to execute goal on project log4j-plugins: Could not
>>>>>> resolve dependencies for project
>>>>>> org.apache.logging.log4j:log4j-plugins:jar:3.0.0-SNAPSHOT: Could not
>>>>>> find artifact org.apache.logging.log4j:log4j-api:jar:tests:3.0.0-SNAPSHOT
>>>>>>
>>>>>> I have checked Travis[1] and Jenkins[2], their end doesn't look bright either.
>>>>>>
>>>>>> How do you people deal with this? How do you develop? Which branch
>>>>>> shall I use to base JsonTemplateLayout?
>>>>>>
>>>>>> Kind regards.
>>>>>>
>>>>>> [1] https://travis-ci.org/apache/logging-log4j2/builds
>>>>>> [2] https://builds.apache.org/view/L/view/Logging/
>>>>>>
>>>>>
>>>>>
>>>
>>>
>>>
>>> --
>>> Matt Sicker <bo...@gmail.com>
>
Re: unstable master branch
Posted by Volkan Yazıcı <vo...@gmail.com>.
I am pretty confident that the "master" is broken:
$ /home/vy/Software/share/java/jdk/8/bin/java -version
openjdk version "1.8.0_232"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_232-b09)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.232-b09, mixed mode)
$ /home/vy/Software/share/java/jdk/11/bin/java -version
openjdk version "11.0.2" 2019-01-15
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.2+9)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.2+9, mixed mode)
$ docker run -it \
-v $HOME/.m2:/root/.m2 \
-v /home/vy/Projects/log4j2:/log4j2 \
-v /home/vy/Software/share/java/jdk/8:/home/vy/Software/share/java/jdk/8 \
-v /home/vy/Software/share/java/jdk/11:/home/vy/Software/share/java/jdk/11 \
adoptopenjdk/openjdk8:latest \
/bin/bash
# cd /log4j2
# ./mvnw clean package -Dmaven.test.skip=true
These combinations produce exactly the same error I shared earlier.
I will really appreciate some help. I am done with my single-file
simple JSON parser[1]. But since I am not able to compile the project
anymore, I cannot proceed with incorporating the last bit of changes
to remove the Jackson dependency.
Kind regards.
[1] https://gist.github.com/vy/a8018bbdf5442e998f95008f5959e775
On Thu, Mar 5, 2020 at 4:34 PM Volkan Yazıcı <vo...@gmail.com> wrote:
>
> Nope, neither "install" works; fails with the same message.
>
> On Thu, Mar 5, 2020 at 4:25 PM Matt Sicker <bo...@gmail.com> wrote:
> >
> > It could be an issue in the pom somewhere. Does "install" instead of
> > "package" work for you?
> >
> > On Thu, 5 Mar 2020 at 02:27, Volkan Yazıcı <vo...@gmail.com> wrote:
> > >
> > > Even after a clean checkout:
> > >
> > > $ cd /tmp
> > > $ git clone https://github.com/apache/logging-log4j2.git log4j2
> > > $ cd log4j2
> > > $ m -rf ~/.m2/repository/org/apache/logging
> > > $ ./mvnw package -Dmaven.test.skip=true
> > >
> > > I still get the very same error. I see that Jenkins is still failing,
> > > though Travis has recovered yesterday after a change of yours. What
> > > might I be missing? How can I further debug the problem?
> > >
> > > On Wed, Mar 4, 2020 at 5:11 PM Ralph Goers <ra...@dslextreme.com> wrote:
> > > >
> > > > My typical development follow 1 of 2 paths.
> > > >
> > > > 1. I am doing a patch or new feature targeted at the 2.x release train. I do my initial development on the release-2.x branch. Once it is fully tested I cherry-pick it (when possible) to the master branch. If I can’t cherry-pick it I manually copy the changes. For both release-2.x and master I ALWAYS run full builds before committing. I only run the builds on Mac OS.
> > > > 2. I am creating a patch or new feature only targeted at master. I do all my development and testing on master. I ALWAYS run a full build before committing. I only run the builds on Mac OS.
> > > >
> > > > Frequently I notice that the Jenkins builds on Windows fail. I recently fixed the bad tests on the release-2.x branch as I don’t want to cut a release knowing there are failing unit tests. Since we have no plans to cut a 3.0 release soon I haven’t worried about Windows too much since, while I find the emails annoying, they aren’t blocking me.
> > > >
> > > > I can’t recall ever seeing the error below. It implies that the log4j-plugins module is being built before the log4j-api module, which never happens for me. I suppose it would happen if you try to build the log4j-plugin module from its directory without having built the rest of log4j.
> > > >
> > > > Ralph
> > > >
> > > > > On Mar 4, 2020, at 4:51 AM, Volkan Yazıcı <vo...@gmail.com> wrote:
> > > > >
> > > > > Hello,
> > > > >
> > > > > While developing it is really difficult to keep up with the master
> > > > > branch, it continuously gets broken. master and release-2.x diverge a
> > > > > lot as well, hence I am sitting on the fence for whether I should base
> > > > > my changes on master or release-2.x. This is my current state:
> > > > >
> > > > > $ git remote -v
> > > > > origin git@github.com:vy/log4j2.git (fetch)
> > > > > origin git@github.com:vy/log4j2.git (push)
> > > > > upstream https://github.com/apache/logging-log4j2.git (fetch)
> > > > > upstream https://github.com/apache/logging-log4j2.git (push)
> > > > > $ git fetch -pP upstream
> > > > > $ git rebase upstream/master
> > > > > Current branch master is up to date.
> > > > > $ git diff master..upstream/master
> > > > > $ rm -rf ~/.m2/repository/org/apache/logging
> > > > > $ ./mvnw clean package -Dmaven.test.skip=true
> > > > > ...
> > > > > [ERROR] Failed to execute goal on project log4j-plugins: Could not
> > > > > resolve dependencies for project
> > > > > org.apache.logging.log4j:log4j-plugins:jar:3.0.0-SNAPSHOT: Could not
> > > > > find artifact org.apache.logging.log4j:log4j-api:jar:tests:3.0.0-SNAPSHOT
> > > > >
> > > > > I have checked Travis[1] and Jenkins[2], their end doesn't look bright either.
> > > > >
> > > > > How do you people deal with this? How do you develop? Which branch
> > > > > shall I use to base JsonTemplateLayout?
> > > > >
> > > > > Kind regards.
> > > > >
> > > > > [1] https://travis-ci.org/apache/logging-log4j2/builds
> > > > > [2] https://builds.apache.org/view/L/view/Logging/
> > > > >
> > > >
> > > >
> >
> >
> >
> > --
> > Matt Sicker <bo...@gmail.com>
Re: unstable master branch
Posted by Volkan Yazıcı <vo...@gmail.com>.
Nope, neither "install" works; fails with the same message.
On Thu, Mar 5, 2020 at 4:25 PM Matt Sicker <bo...@gmail.com> wrote:
>
> It could be an issue in the pom somewhere. Does "install" instead of
> "package" work for you?
>
> On Thu, 5 Mar 2020 at 02:27, Volkan Yazıcı <vo...@gmail.com> wrote:
> >
> > Even after a clean checkout:
> >
> > $ cd /tmp
> > $ git clone https://github.com/apache/logging-log4j2.git log4j2
> > $ cd log4j2
> > $ m -rf ~/.m2/repository/org/apache/logging
> > $ ./mvnw package -Dmaven.test.skip=true
> >
> > I still get the very same error. I see that Jenkins is still failing,
> > though Travis has recovered yesterday after a change of yours. What
> > might I be missing? How can I further debug the problem?
> >
> > On Wed, Mar 4, 2020 at 5:11 PM Ralph Goers <ra...@dslextreme.com> wrote:
> > >
> > > My typical development follow 1 of 2 paths.
> > >
> > > 1. I am doing a patch or new feature targeted at the 2.x release train. I do my initial development on the release-2.x branch. Once it is fully tested I cherry-pick it (when possible) to the master branch. If I can’t cherry-pick it I manually copy the changes. For both release-2.x and master I ALWAYS run full builds before committing. I only run the builds on Mac OS.
> > > 2. I am creating a patch or new feature only targeted at master. I do all my development and testing on master. I ALWAYS run a full build before committing. I only run the builds on Mac OS.
> > >
> > > Frequently I notice that the Jenkins builds on Windows fail. I recently fixed the bad tests on the release-2.x branch as I don’t want to cut a release knowing there are failing unit tests. Since we have no plans to cut a 3.0 release soon I haven’t worried about Windows too much since, while I find the emails annoying, they aren’t blocking me.
> > >
> > > I can’t recall ever seeing the error below. It implies that the log4j-plugins module is being built before the log4j-api module, which never happens for me. I suppose it would happen if you try to build the log4j-plugin module from its directory without having built the rest of log4j.
> > >
> > > Ralph
> > >
> > > > On Mar 4, 2020, at 4:51 AM, Volkan Yazıcı <vo...@gmail.com> wrote:
> > > >
> > > > Hello,
> > > >
> > > > While developing it is really difficult to keep up with the master
> > > > branch, it continuously gets broken. master and release-2.x diverge a
> > > > lot as well, hence I am sitting on the fence for whether I should base
> > > > my changes on master or release-2.x. This is my current state:
> > > >
> > > > $ git remote -v
> > > > origin git@github.com:vy/log4j2.git (fetch)
> > > > origin git@github.com:vy/log4j2.git (push)
> > > > upstream https://github.com/apache/logging-log4j2.git (fetch)
> > > > upstream https://github.com/apache/logging-log4j2.git (push)
> > > > $ git fetch -pP upstream
> > > > $ git rebase upstream/master
> > > > Current branch master is up to date.
> > > > $ git diff master..upstream/master
> > > > $ rm -rf ~/.m2/repository/org/apache/logging
> > > > $ ./mvnw clean package -Dmaven.test.skip=true
> > > > ...
> > > > [ERROR] Failed to execute goal on project log4j-plugins: Could not
> > > > resolve dependencies for project
> > > > org.apache.logging.log4j:log4j-plugins:jar:3.0.0-SNAPSHOT: Could not
> > > > find artifact org.apache.logging.log4j:log4j-api:jar:tests:3.0.0-SNAPSHOT
> > > >
> > > > I have checked Travis[1] and Jenkins[2], their end doesn't look bright either.
> > > >
> > > > How do you people deal with this? How do you develop? Which branch
> > > > shall I use to base JsonTemplateLayout?
> > > >
> > > > Kind regards.
> > > >
> > > > [1] https://travis-ci.org/apache/logging-log4j2/builds
> > > > [2] https://builds.apache.org/view/L/view/Logging/
> > > >
> > >
> > >
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
Re: unstable master branch
Posted by Matt Sicker <bo...@gmail.com>.
It could be an issue in the pom somewhere. Does "install" instead of
"package" work for you?
On Thu, 5 Mar 2020 at 02:27, Volkan Yazıcı <vo...@gmail.com> wrote:
>
> Even after a clean checkout:
>
> $ cd /tmp
> $ git clone https://github.com/apache/logging-log4j2.git log4j2
> $ cd log4j2
> $ m -rf ~/.m2/repository/org/apache/logging
> $ ./mvnw package -Dmaven.test.skip=true
>
> I still get the very same error. I see that Jenkins is still failing,
> though Travis has recovered yesterday after a change of yours. What
> might I be missing? How can I further debug the problem?
>
> On Wed, Mar 4, 2020 at 5:11 PM Ralph Goers <ra...@dslextreme.com> wrote:
> >
> > My typical development follow 1 of 2 paths.
> >
> > 1. I am doing a patch or new feature targeted at the 2.x release train. I do my initial development on the release-2.x branch. Once it is fully tested I cherry-pick it (when possible) to the master branch. If I can’t cherry-pick it I manually copy the changes. For both release-2.x and master I ALWAYS run full builds before committing. I only run the builds on Mac OS.
> > 2. I am creating a patch or new feature only targeted at master. I do all my development and testing on master. I ALWAYS run a full build before committing. I only run the builds on Mac OS.
> >
> > Frequently I notice that the Jenkins builds on Windows fail. I recently fixed the bad tests on the release-2.x branch as I don’t want to cut a release knowing there are failing unit tests. Since we have no plans to cut a 3.0 release soon I haven’t worried about Windows too much since, while I find the emails annoying, they aren’t blocking me.
> >
> > I can’t recall ever seeing the error below. It implies that the log4j-plugins module is being built before the log4j-api module, which never happens for me. I suppose it would happen if you try to build the log4j-plugin module from its directory without having built the rest of log4j.
> >
> > Ralph
> >
> > > On Mar 4, 2020, at 4:51 AM, Volkan Yazıcı <vo...@gmail.com> wrote:
> > >
> > > Hello,
> > >
> > > While developing it is really difficult to keep up with the master
> > > branch, it continuously gets broken. master and release-2.x diverge a
> > > lot as well, hence I am sitting on the fence for whether I should base
> > > my changes on master or release-2.x. This is my current state:
> > >
> > > $ git remote -v
> > > origin git@github.com:vy/log4j2.git (fetch)
> > > origin git@github.com:vy/log4j2.git (push)
> > > upstream https://github.com/apache/logging-log4j2.git (fetch)
> > > upstream https://github.com/apache/logging-log4j2.git (push)
> > > $ git fetch -pP upstream
> > > $ git rebase upstream/master
> > > Current branch master is up to date.
> > > $ git diff master..upstream/master
> > > $ rm -rf ~/.m2/repository/org/apache/logging
> > > $ ./mvnw clean package -Dmaven.test.skip=true
> > > ...
> > > [ERROR] Failed to execute goal on project log4j-plugins: Could not
> > > resolve dependencies for project
> > > org.apache.logging.log4j:log4j-plugins:jar:3.0.0-SNAPSHOT: Could not
> > > find artifact org.apache.logging.log4j:log4j-api:jar:tests:3.0.0-SNAPSHOT
> > >
> > > I have checked Travis[1] and Jenkins[2], their end doesn't look bright either.
> > >
> > > How do you people deal with this? How do you develop? Which branch
> > > shall I use to base JsonTemplateLayout?
> > >
> > > Kind regards.
> > >
> > > [1] https://travis-ci.org/apache/logging-log4j2/builds
> > > [2] https://builds.apache.org/view/L/view/Logging/
> > >
> >
> >
--
Matt Sicker <bo...@gmail.com>
Re: unstable master branch
Posted by Volkan Yazıcı <vo...@gmail.com>.
Even after a clean checkout:
$ cd /tmp
$ git clone https://github.com/apache/logging-log4j2.git log4j2
$ cd log4j2
$ m -rf ~/.m2/repository/org/apache/logging
$ ./mvnw package -Dmaven.test.skip=true
I still get the very same error. I see that Jenkins is still failing,
though Travis has recovered yesterday after a change of yours. What
might I be missing? How can I further debug the problem?
On Wed, Mar 4, 2020 at 5:11 PM Ralph Goers <ra...@dslextreme.com> wrote:
>
> My typical development follow 1 of 2 paths.
>
> 1. I am doing a patch or new feature targeted at the 2.x release train. I do my initial development on the release-2.x branch. Once it is fully tested I cherry-pick it (when possible) to the master branch. If I can’t cherry-pick it I manually copy the changes. For both release-2.x and master I ALWAYS run full builds before committing. I only run the builds on Mac OS.
> 2. I am creating a patch or new feature only targeted at master. I do all my development and testing on master. I ALWAYS run a full build before committing. I only run the builds on Mac OS.
>
> Frequently I notice that the Jenkins builds on Windows fail. I recently fixed the bad tests on the release-2.x branch as I don’t want to cut a release knowing there are failing unit tests. Since we have no plans to cut a 3.0 release soon I haven’t worried about Windows too much since, while I find the emails annoying, they aren’t blocking me.
>
> I can’t recall ever seeing the error below. It implies that the log4j-plugins module is being built before the log4j-api module, which never happens for me. I suppose it would happen if you try to build the log4j-plugin module from its directory without having built the rest of log4j.
>
> Ralph
>
> > On Mar 4, 2020, at 4:51 AM, Volkan Yazıcı <vo...@gmail.com> wrote:
> >
> > Hello,
> >
> > While developing it is really difficult to keep up with the master
> > branch, it continuously gets broken. master and release-2.x diverge a
> > lot as well, hence I am sitting on the fence for whether I should base
> > my changes on master or release-2.x. This is my current state:
> >
> > $ git remote -v
> > origin git@github.com:vy/log4j2.git (fetch)
> > origin git@github.com:vy/log4j2.git (push)
> > upstream https://github.com/apache/logging-log4j2.git (fetch)
> > upstream https://github.com/apache/logging-log4j2.git (push)
> > $ git fetch -pP upstream
> > $ git rebase upstream/master
> > Current branch master is up to date.
> > $ git diff master..upstream/master
> > $ rm -rf ~/.m2/repository/org/apache/logging
> > $ ./mvnw clean package -Dmaven.test.skip=true
> > ...
> > [ERROR] Failed to execute goal on project log4j-plugins: Could not
> > resolve dependencies for project
> > org.apache.logging.log4j:log4j-plugins:jar:3.0.0-SNAPSHOT: Could not
> > find artifact org.apache.logging.log4j:log4j-api:jar:tests:3.0.0-SNAPSHOT
> >
> > I have checked Travis[1] and Jenkins[2], their end doesn't look bright either.
> >
> > How do you people deal with this? How do you develop? Which branch
> > shall I use to base JsonTemplateLayout?
> >
> > Kind regards.
> >
> > [1] https://travis-ci.org/apache/logging-log4j2/builds
> > [2] https://builds.apache.org/view/L/view/Logging/
> >
>
>
Re: unstable master branch
Posted by Ralph Goers <ra...@dslextreme.com>.
My typical development follow 1 of 2 paths.
1. I am doing a patch or new feature targeted at the 2.x release train. I do my initial development on the release-2.x branch. Once it is fully tested I cherry-pick it (when possible) to the master branch. If I can’t cherry-pick it I manually copy the changes. For both release-2.x and master I ALWAYS run full builds before committing. I only run the builds on Mac OS.
2. I am creating a patch or new feature only targeted at master. I do all my development and testing on master. I ALWAYS run a full build before committing. I only run the builds on Mac OS.
Frequently I notice that the Jenkins builds on Windows fail. I recently fixed the bad tests on the release-2.x branch as I don’t want to cut a release knowing there are failing unit tests. Since we have no plans to cut a 3.0 release soon I haven’t worried about Windows too much since, while I find the emails annoying, they aren’t blocking me.
I can’t recall ever seeing the error below. It implies that the log4j-plugins module is being built before the log4j-api module, which never happens for me. I suppose it would happen if you try to build the log4j-plugin module from its directory without having built the rest of log4j.
Ralph
> On Mar 4, 2020, at 4:51 AM, Volkan Yazıcı <vo...@gmail.com> wrote:
>
> Hello,
>
> While developing it is really difficult to keep up with the master
> branch, it continuously gets broken. master and release-2.x diverge a
> lot as well, hence I am sitting on the fence for whether I should base
> my changes on master or release-2.x. This is my current state:
>
> $ git remote -v
> origin git@github.com:vy/log4j2.git (fetch)
> origin git@github.com:vy/log4j2.git (push)
> upstream https://github.com/apache/logging-log4j2.git (fetch)
> upstream https://github.com/apache/logging-log4j2.git (push)
> $ git fetch -pP upstream
> $ git rebase upstream/master
> Current branch master is up to date.
> $ git diff master..upstream/master
> $ rm -rf ~/.m2/repository/org/apache/logging
> $ ./mvnw clean package -Dmaven.test.skip=true
> ...
> [ERROR] Failed to execute goal on project log4j-plugins: Could not
> resolve dependencies for project
> org.apache.logging.log4j:log4j-plugins:jar:3.0.0-SNAPSHOT: Could not
> find artifact org.apache.logging.log4j:log4j-api:jar:tests:3.0.0-SNAPSHOT
>
> I have checked Travis[1] and Jenkins[2], their end doesn't look bright either.
>
> How do you people deal with this? How do you develop? Which branch
> shall I use to base JsonTemplateLayout?
>
> Kind regards.
>
> [1] https://travis-ci.org/apache/logging-log4j2/builds
> [2] https://builds.apache.org/view/L/view/Logging/
>
Re: unstable master branch
Posted by Ralph Goers <ra...@dslextreme.com>.
I guess if I had understood I could have told you that. I believe the default-jar configuration is built into the maven jar plugin.
Ralph
> On Mar 21, 2020, at 8:00 AM, Matt Sicker <bo...@gmail.com> wrote:
>
> Great find! I did not know there were two different properties involved
> there. Thanks for digging.
>
> On Sat, Mar 21, 2020 at 09:38 Volkan Yazıcı <vo...@gmail.com> wrote:
>
>> I've finally found and solved the problem! It is right there in my
>> post: -Dmaven.test.skip=true. This causes test-jar generation to be
>> skipped and hence modules with dependencies to test-jars cannot
>> resolve them. One should instead use -DskipTests, which will skip
>> tests, but will still generate the test-jar.
>>
>> Speaking of subtle details ruining a developer's life... Renaming
>> <id>default-jar</id> in maven-jar-plugin configuration to something
>> else also breaks the compilation. Though I did not further dig this
>> down. Just don't do it.
>>
>> On Wed, Mar 4, 2020 at 12:51 PM Volkan Yazıcı <vo...@gmail.com>
>> wrote:
>>>
>>> Hello,
>>>
>>> While developing it is really difficult to keep up with the master
>>> branch, it continuously gets broken. master and release-2.x diverge a
>>> lot as well, hence I am sitting on the fence for whether I should base
>>> my changes on master or release-2.x. This is my current state:
>>>
>>> $ git remote -v
>>> origin git@github.com:vy/log4j2.git (fetch)
>>> origin git@github.com:vy/log4j2.git (push)
>>> upstream https://github.com/apache/logging-log4j2.git (fetch)
>>> upstream https://github.com/apache/logging-log4j2.git (push)
>>> $ git fetch -pP upstream
>>> $ git rebase upstream/master
>>> Current branch master is up to date.
>>> $ git diff master..upstream/master
>>> $ rm -rf ~/.m2/repository/org/apache/logging
>>> $ ./mvnw clean package -Dmaven.test.skip=true
>>> ...
>>> [ERROR] Failed to execute goal on project log4j-plugins: Could not
>>> resolve dependencies for project
>>> org.apache.logging.log4j:log4j-plugins:jar:3.0.0-SNAPSHOT: Could not
>>> find artifact org.apache.logging.log4j:log4j-api:jar:tests:3.0.0-SNAPSHOT
>>>
>>> I have checked Travis[1] and Jenkins[2], their end doesn't look bright
>> either.
>>>
>>> How do you people deal with this? How do you develop? Which branch
>>> shall I use to base JsonTemplateLayout?
>>>
>>> Kind regards.
>>>
>>> [1] https://travis-ci.org/apache/logging-log4j2/builds
>>> [2] https://builds.apache.org/view/L/view/Logging/
>>
> --
> Matt Sicker <bo...@gmail.com>
Re: unstable master branch
Posted by Matt Sicker <bo...@gmail.com>.
Great find! I did not know there were two different properties involved
there. Thanks for digging.
On Sat, Mar 21, 2020 at 09:38 Volkan Yazıcı <vo...@gmail.com> wrote:
> I've finally found and solved the problem! It is right there in my
> post: -Dmaven.test.skip=true. This causes test-jar generation to be
> skipped and hence modules with dependencies to test-jars cannot
> resolve them. One should instead use -DskipTests, which will skip
> tests, but will still generate the test-jar.
>
> Speaking of subtle details ruining a developer's life... Renaming
> <id>default-jar</id> in maven-jar-plugin configuration to something
> else also breaks the compilation. Though I did not further dig this
> down. Just don't do it.
>
> On Wed, Mar 4, 2020 at 12:51 PM Volkan Yazıcı <vo...@gmail.com>
> wrote:
> >
> > Hello,
> >
> > While developing it is really difficult to keep up with the master
> > branch, it continuously gets broken. master and release-2.x diverge a
> > lot as well, hence I am sitting on the fence for whether I should base
> > my changes on master or release-2.x. This is my current state:
> >
> > $ git remote -v
> > origin git@github.com:vy/log4j2.git (fetch)
> > origin git@github.com:vy/log4j2.git (push)
> > upstream https://github.com/apache/logging-log4j2.git (fetch)
> > upstream https://github.com/apache/logging-log4j2.git (push)
> > $ git fetch -pP upstream
> > $ git rebase upstream/master
> > Current branch master is up to date.
> > $ git diff master..upstream/master
> > $ rm -rf ~/.m2/repository/org/apache/logging
> > $ ./mvnw clean package -Dmaven.test.skip=true
> > ...
> > [ERROR] Failed to execute goal on project log4j-plugins: Could not
> > resolve dependencies for project
> > org.apache.logging.log4j:log4j-plugins:jar:3.0.0-SNAPSHOT: Could not
> > find artifact org.apache.logging.log4j:log4j-api:jar:tests:3.0.0-SNAPSHOT
> >
> > I have checked Travis[1] and Jenkins[2], their end doesn't look bright
> either.
> >
> > How do you people deal with this? How do you develop? Which branch
> > shall I use to base JsonTemplateLayout?
> >
> > Kind regards.
> >
> > [1] https://travis-ci.org/apache/logging-log4j2/builds
> > [2] https://builds.apache.org/view/L/view/Logging/
>
--
Matt Sicker <bo...@gmail.com>
Re: unstable master branch
Posted by Volkan Yazıcı <vo...@gmail.com>.
I've finally found and solved the problem! It is right there in my
post: -Dmaven.test.skip=true. This causes test-jar generation to be
skipped and hence modules with dependencies to test-jars cannot
resolve them. One should instead use -DskipTests, which will skip
tests, but will still generate the test-jar.
Speaking of subtle details ruining a developer's life... Renaming
<id>default-jar</id> in maven-jar-plugin configuration to something
else also breaks the compilation. Though I did not further dig this
down. Just don't do it.
On Wed, Mar 4, 2020 at 12:51 PM Volkan Yazıcı <vo...@gmail.com> wrote:
>
> Hello,
>
> While developing it is really difficult to keep up with the master
> branch, it continuously gets broken. master and release-2.x diverge a
> lot as well, hence I am sitting on the fence for whether I should base
> my changes on master or release-2.x. This is my current state:
>
> $ git remote -v
> origin git@github.com:vy/log4j2.git (fetch)
> origin git@github.com:vy/log4j2.git (push)
> upstream https://github.com/apache/logging-log4j2.git (fetch)
> upstream https://github.com/apache/logging-log4j2.git (push)
> $ git fetch -pP upstream
> $ git rebase upstream/master
> Current branch master is up to date.
> $ git diff master..upstream/master
> $ rm -rf ~/.m2/repository/org/apache/logging
> $ ./mvnw clean package -Dmaven.test.skip=true
> ...
> [ERROR] Failed to execute goal on project log4j-plugins: Could not
> resolve dependencies for project
> org.apache.logging.log4j:log4j-plugins:jar:3.0.0-SNAPSHOT: Could not
> find artifact org.apache.logging.log4j:log4j-api:jar:tests:3.0.0-SNAPSHOT
>
> I have checked Travis[1] and Jenkins[2], their end doesn't look bright either.
>
> How do you people deal with this? How do you develop? Which branch
> shall I use to base JsonTemplateLayout?
>
> Kind regards.
>
> [1] https://travis-ci.org/apache/logging-log4j2/builds
> [2] https://builds.apache.org/view/L/view/Logging/