[GitHub] [lucene] madrob commented on a change in pull request #343: LUCENE-10131: Add backcompat indices for 8.10 and add LUCENE_8_10_0 to Version

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #343:
URL: https://github.com/apache/lucene/pull/343#discussion_r719652888



##########
File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java
##########
@@ -685,7 +686,7 @@ public void testAllVersionHaveCfsAndNocfs() {
   }
 
   public void testAllVersionsTested() throws Exception {
-    Pattern constantPattern = Pattern.compile("LUCENE_(\\d+)_(\\d+)_(\\d+)(_ALPHA|_BETA)?");
+    Pattern constantPattern = Pattern.compile("LUCENE_(\\d+)_(\\d{1,2})_(\\d+)(_ALPHA|_BETA)?");

Review comment:
       I don't think this is necessary.

##########
File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java
##########
@@ -383,6 +383,7 @@ public void testCreateEmptyIndex() throws Exception {
     "sorted.8.0.0",
     "sorted.8.1.0",
     "sorted.8.1.1",
+    "sorted.8.10.0",

Review comment:
       I think you also need an addition above to `oldNames`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org