[GitHub] [superset] ktmud commented on pull request #13144: feat: Add error pages

[GitBox <gi...@apache.org>]

ktmud commented on pull request #13144:
URL: https://github.com/apache/superset/pull/13144#issuecomment-780087593


   Maybe you can take advantage of the [html-webpack-plugin](https://webpack.js.org/plugins/html-webpack-plugin/) to build a static error pages with all styles and images embedded?
   
   I'm also wondering whether it makes sense to let Python/Jinja render 404 and 403 first, and only fallback to a static 500 page in Nginx if the Python render fails. So you can do more advanced stuff with these error pages like having global navs and render more customized error messages, etc


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org