You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/30 21:38:59 UTC
[GitHub] ogirardot opened a new pull request #4626: [AIRFLOW-3792] Fix in
BigQuery hook queryParameters and useLegacySQL flags
ogirardot opened a new pull request #4626: [AIRFLOW-3792] Fix in BigQuery hook queryParameters and useLegacySQL flags
URL: https://github.com/apache/airflow/pull/4626
### Description
This PR fixes a bug in BigQuery Hook when using :
- useLegacySQL to False
- or queryParameters, because since 1.10 the queryParameters are validated as dict instead of what google's API expects (a list of dict)
### Tests
- [ x] My PR adds the following unit tests : in `contrib/test_bigquery_hook.py` a test called `test_run_query_sql_dialect_legacy_with_query_params` which tests both the proper form of query params and the legacy sql flag set to False in conjonction.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
### Documentation
No new thing, just a bug fix.
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services