You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/11 09:17:04 UTC
[GitHub] [camel] orpiske opened a new pull request #5073: CAMEL-16179: prevent a NPE on the MongoDB component if unable to resolve the DB connection
orpiske opened a new pull request #5073:
URL: https://github.com/apache/camel/pull/5073
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #5073: CAMEL-16179: prevent a NPE on the MongoDB component if unable to resolve the DB connection
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #5073:
URL: https://github.com/apache/camel/pull/5073#issuecomment-777306108
> It would be good to make this autowried = true so the component will auto configure it present
>
> https://github.com/apache/camel/blob/6377a997c2a831ab8fc80cf5eca7d552c94bc18a/components/camel-mongodb/src/main/java/org/apache/camel/component/mongodb/MongoDbComponent.java#L43
Thanks Claus, let me give it a try with that instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #5073: CAMEL-16179: prevent a NPE on the MongoDB component if unable to resolve the DB connection
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #5073:
URL: https://github.com/apache/camel/pull/5073#issuecomment-777312337
> Oh just mind that the autowried will just do this once. You NPE fix is also correct, in case there was no mongodb client at all.
Ahh, thanks for the clarification. I will keep the original changes + the autowired.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #5073: CAMEL-16179: prevent a NPE on the MongoDB component if unable to resolve the DB connection
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #5073:
URL: https://github.com/apache/camel/pull/5073
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #5073: CAMEL-16179: prevent a NPE on the MongoDB component if unable to resolve the DB connection
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5073:
URL: https://github.com/apache/camel/pull/5073#issuecomment-777311107
Oh just mind that the autowried will just do this once. You NPE fix is also correct, in case there was no mongodb client at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #5073: CAMEL-16179: prevent a NPE on the MongoDB component if unable to resolve the DB connection
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5073:
URL: https://github.com/apache/camel/pull/5073#issuecomment-777305159
It would be good to make this autowried = true so the component will auto configure it present
https://github.com/apache/camel/blob/6377a997c2a831ab8fc80cf5eca7d552c94bc18a/components/camel-mongodb/src/main/java/org/apache/camel/component/mongodb/MongoDbComponent.java#L43
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org