You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/16 21:28:21 UTC

[GitHub] [arrow] nealrichardson commented on a change in pull request #8459: ARROW-10195: [C++] Add string struct extract kernel using re2

nealrichardson commented on a change in pull request #8459:
URL: https://github.com/apache/arrow/pull/8459#discussion_r506729025



##########
File path: cpp/CMakeLists.txt
##########
@@ -735,6 +735,7 @@ endif()
 
 if(ARROW_WITH_UTF8PROC)
   list(APPEND ARROW_LINK_LIBS utf8proc::utf8proc)
+  list(APPEND ARROW_LINK_LIBS re2)

Review comment:
       Rather than opting out of dependencies, would it make more sense to have an `ARROW_COMPUTE_STRINGS` (feel free to pick a better name) feature flag that, if enabled, requires utf8proc and re2? Unlike the compression libraries that have the `ARROW_WITH_X` flags, these dependencies are tied to specific functionality that can't really exist without them, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org