You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/22 15:24:58 UTC
[GitHub] [incubator-mxnet] ptrendx opened a new pull request #18984: Fix isnan usage in RTC
ptrendx opened a new pull request #18984:
URL: https://github.com/apache/incubator-mxnet/pull/18984
## Description ##
Fixes problem reported in #18622, where the non-templated version of `isnan` was used inside min and max functions, causing failures for integer types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #18984: Fix isnan usage in RTC
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #18984:
URL: https://github.com/apache/incubator-mxnet/pull/18984#issuecomment-679133372
Yes, I can and will add a test (sorry for not answering it earlier).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18984: Fix isnan usage in RTC
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18984:
URL: https://github.com/apache/incubator-mxnet/pull/18984#issuecomment-678653766
Hey @ptrendx , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [clang, edge, centos-gpu, miscellaneous, sanity, website, windows-gpu, centos-cpu, unix-cpu, windows-cpu, unix-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sxjscience merged pull request #18984: Fix isnan usage in RTC
Posted by GitBox <gi...@apache.org>.
sxjscience merged pull request #18984:
URL: https://github.com/apache/incubator-mxnet/pull/18984
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #18984: Fix isnan usage in RTC
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #18984:
URL: https://github.com/apache/incubator-mxnet/pull/18984#issuecomment-679203095
I added testing of integer datatype to maximum and minimum functions - currently `test_np_binary_funcs` by default only checks floating point types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18984: Fix isnan usage in RTC
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18984:
URL: https://github.com/apache/incubator-mxnet/pull/18984#issuecomment-679319721
Jenkins CI successfully triggered : [windows-cpu, centos-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on pull request #18984: Fix isnan usage in RTC
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on pull request #18984:
URL: https://github.com/apache/incubator-mxnet/pull/18984#issuecomment-679211210
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sxjscience commented on pull request #18984: Fix isnan usage in RTC
Posted by GitBox <gi...@apache.org>.
sxjscience commented on pull request #18984:
URL: https://github.com/apache/incubator-mxnet/pull/18984#issuecomment-678965651
Currently it's triggered if we train the ELECTRA-small model in GluonNLP: https://github.com/dmlc/gluon-nlp/tree/master/scripts/pretraining, which is somehow complicated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on pull request #18984: Fix isnan usage in RTC
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on pull request #18984:
URL: https://github.com/apache/incubator-mxnet/pull/18984#issuecomment-678916298
I mean we discovered a clear case where it fails, so why not add a test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #18984: Fix isnan usage in RTC
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #18984:
URL: https://github.com/apache/incubator-mxnet/pull/18984#issuecomment-679319675
@mxnet-bot run ci [centos-gpu, windows-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on pull request #18984: Fix isnan usage in RTC
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on pull request #18984:
URL: https://github.com/apache/incubator-mxnet/pull/18984#issuecomment-678998843
Maybe @ptrendx can extract the relevant part and create a unit test out of it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #18984: Fix isnan usage in RTC
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #18984:
URL: https://github.com/apache/incubator-mxnet/pull/18984#issuecomment-679404551
@marcoabreu Do you think this PR is good to go?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org