svn commit: r1675365 - in /lucene/dev/trunk: ./ lucene/ lucene/core/ lucene/core/src/java/org/apache/lucene/search/Explanation.java

[jp...@apache.org]

Author: jpountz
Date: Wed Apr 22 14:02:58 2015
New Revision: 1675365

URL: http://svn.apache.org/r1675365
Log:
LUCENE-6446: Fix method visibility and trappy factory method.

Modified:
    lucene/dev/trunk/   (props changed)
    lucene/dev/trunk/lucene/   (props changed)
    lucene/dev/trunk/lucene/core/   (props changed)
    lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Explanation.java

Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Explanation.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Explanation.java?rev=1675365&r1=1675364&r2=1675365&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Explanation.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/search/Explanation.java Wed Apr 22 14:02:58 2015
@@ -25,7 +25,7 @@ import java.util.List;
 import java.util.Objects;
 
 /** Expert: Describes the score computation for document and query. */
-public class Explanation {
+public final class Explanation {
 
   /**
    * Create a new explanation for a match.
@@ -51,14 +51,14 @@ public class Explanation {
    * Create a new explanation for a document which does not match.
    */
   public static Explanation noMatch(String description, Collection<Explanation> details) {
-    return new Explanation(false, 0f, description, Collections.emptyList());
+    return new Explanation(false, 0f, description, details);
   }
 
   /**
    * Create a new explanation for a document which does not match.
    */
   public static Explanation noMatch(String description, Explanation... details) {
-    return new Explanation(false, 0f, description, Collections.emptyList());
+    return new Explanation(false, 0f, description, Arrays.asList(details));
   }
 
   private final boolean match;                          // whether the document matched
@@ -90,11 +90,7 @@ public class Explanation {
   /** A description of this explanation node. */
   public String getDescription() { return description; }
 
-  /**
-   * A short one line summary which should contain all high level
-   * information about this Explanation, without the "Details"
-   */
-  protected String getSummary() {
+  private String getSummary() {
     return getValue() + " = " + getDescription();
   }
   
@@ -108,7 +104,8 @@ public class Explanation {
   public String toString() {
     return toString(0);
   }
-  protected String toString(int depth) {
+
+  private String toString(int depth) {
     StringBuilder buffer = new StringBuilder();
     for (int i = 0; i < depth; i++) {
       buffer.append("  ");