You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Lars George (JIRA)" <ji...@apache.org> on 2011/01/14 15:04:45 UTC
[jira] Created: (WHIRR-206) [HBase] Extract strings to a
HBaseServiceConstants interface
[HBase] Extract strings to a HBaseServiceConstants interface
------------------------------------------------------------
Key: WHIRR-206
URL: https://issues.apache.org/jira/browse/WHIRR-206
Project: Whirr
Issue Type: Improvement
Affects Versions: 0.3.0
Reporter: Lars George
Assignee: Lars George
Priority: Trivial
Fix For: 0.3.0
This is trivial but makes sense to find common usages of the same values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-206) [HBase] Extract strings to a
HBaseServiceConstants interface
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars George updated WHIRR-206:
------------------------------
Status: Open (was: Patch Available)
Wrong usage of interface. Redo as class.
> [HBase] Extract strings to a HBaseServiceConstants interface
> ------------------------------------------------------------
>
> Key: WHIRR-206
> URL: https://issues.apache.org/jira/browse/WHIRR-206
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-206.patch, WHIRR-206.patch
>
>
> This is trivial but makes sense to find common usages of the same values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-206) [HBase] Extract strings to a
HBaseServiceConstants interface
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981868#action_12981868 ]
Lars George commented on WHIRR-206:
-----------------------------------
Oh, missed your comment. Bummer.
OK, I'll redo the lot ;(
> [HBase] Extract strings to a HBaseServiceConstants interface
> ------------------------------------------------------------
>
> Key: WHIRR-206
> URL: https://issues.apache.org/jira/browse/WHIRR-206
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-206.patch, WHIRR-206.patch
>
>
> This is trivial but makes sense to find common usages of the same values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-206) [HBase] Extract strings to a
HBaseServiceConstants interface
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars George updated WHIRR-206:
------------------------------
Status: Patch Available (was: Open)
Refactored to use class instead of interface.
> [HBase] Extract strings to a HBaseServiceConstants interface
> ------------------------------------------------------------
>
> Key: WHIRR-206
> URL: https://issues.apache.org/jira/browse/WHIRR-206
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-206.patch, WHIRR-206.patch, WHIRR-206.patch
>
>
> This is trivial but makes sense to find common usages of the same values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-206) [HBase] Extract strings to a
HBaseServiceConstants interface
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars George updated WHIRR-206:
------------------------------
Attachment: WHIRR-206.patch
Redone patch, sorry for the hassle.
> [HBase] Extract strings to a HBaseServiceConstants interface
> ------------------------------------------------------------
>
> Key: WHIRR-206
> URL: https://issues.apache.org/jira/browse/WHIRR-206
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-206.patch, WHIRR-206.patch
>
>
> This is trivial but makes sense to find common usages of the same values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-206) [HBase] Extract strings to a
HBaseServiceConstants interface
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars George updated WHIRR-206:
------------------------------
Attachment: WHIRR-206.patch
> [HBase] Extract strings to a HBaseServiceConstants interface
> ------------------------------------------------------------
>
> Key: WHIRR-206
> URL: https://issues.apache.org/jira/browse/WHIRR-206
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-206.patch, WHIRR-206.patch, WHIRR-206.patch
>
>
> This is trivial but makes sense to find common usages of the same values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-206) [HBase] Extract strings to a
HBaseServiceConstants interface
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated WHIRR-206:
----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I've just committed this. Thanks Lars!
> [HBase] Extract strings to a HBaseServiceConstants interface
> ------------------------------------------------------------
>
> Key: WHIRR-206
> URL: https://issues.apache.org/jira/browse/WHIRR-206
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-206.patch, WHIRR-206.patch, WHIRR-206.patch
>
>
> This is trivial but makes sense to find common usages of the same values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-206) [HBase] Extract strings to a
HBaseServiceConstants interface
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981842#action_12981842 ]
Andrei Savu commented on WHIRR-206:
-----------------------------------
I am unable to apply the patch to the trunk.
> [HBase] Extract strings to a HBaseServiceConstants interface
> ------------------------------------------------------------
>
> Key: WHIRR-206
> URL: https://issues.apache.org/jira/browse/WHIRR-206
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-206.patch
>
>
> This is trivial but makes sense to find common usages of the same values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-206) [HBase] Extract strings to a
HBaseServiceConstants interface
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars George updated WHIRR-206:
------------------------------
Status: Patch Available (was: Open)
> [HBase] Extract strings to a HBaseServiceConstants interface
> ------------------------------------------------------------
>
> Key: WHIRR-206
> URL: https://issues.apache.org/jira/browse/WHIRR-206
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-206.patch
>
>
> This is trivial but makes sense to find common usages of the same values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-206) [HBase] Extract strings to a
HBaseServiceConstants interface
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981858#action_12981858 ]
Tom White commented on WHIRR-206:
---------------------------------
The recommendation from "Effective Java" is to avoid using an interface for constants (since interfaces should be used for behaviour), and instead use a class with static imports. Could we do that here?
> [HBase] Extract strings to a HBaseServiceConstants interface
> ------------------------------------------------------------
>
> Key: WHIRR-206
> URL: https://issues.apache.org/jira/browse/WHIRR-206
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-206.patch
>
>
> This is trivial but makes sense to find common usages of the same values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-206) [HBase] Extract strings to a
HBaseServiceConstants interface
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981849#action_12981849 ]
Lars George commented on WHIRR-206:
-----------------------------------
Hmm, I rebased, so should have been current. Could you paste the error? I will try on trunk too though.
> [HBase] Extract strings to a HBaseServiceConstants interface
> ------------------------------------------------------------
>
> Key: WHIRR-206
> URL: https://issues.apache.org/jira/browse/WHIRR-206
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-206.patch
>
>
> This is trivial but makes sense to find common usages of the same values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-206) [HBase] Extract strings to a
HBaseServiceConstants interface
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars George updated WHIRR-206:
------------------------------
Attachment: WHIRR-206.patch
Moves common strings into a separate file to enable better dependency checks.
> [HBase] Extract strings to a HBaseServiceConstants interface
> ------------------------------------------------------------
>
> Key: WHIRR-206
> URL: https://issues.apache.org/jira/browse/WHIRR-206
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-206.patch
>
>
> This is trivial but makes sense to find common usages of the same values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.