[GitHub] eolivelli commented on a change in pull request #1130: (WIP) handle zookeeper session expire in ensemble watcher

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1130: (WIP) handle zookeeper session expire in ensemble watcher
URL: https://github.com/apache/bookkeeper/pull/1130#discussion_r166687419
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java
 ##########
 @@ -179,8 +179,16 @@ protected AbstractZkLedgerManager(AbstractConfiguration conf, ZooKeeper zk) {
 
     @Override
     public void process(WatchedEvent event) {
-        LOG.info("Received watched event {} from zookeeper based ledger manager.", event);
+        LOG.debug("Received watched event {} from zookeeper based ledger manager.", event);
         if (Event.EventType.None == event.getType()) {
+            if (Event.KeeperState.Expired == event.getState()) {
+                LOG.info("ZooKeeper client expired on ledger manager.");
 
 Review comment:
   Maybe it would be useful to log the session id, with the prev code we had the event, now       the event is logged at debug level. Don't know if event.toString contained the session id..
   Anyway while analyzing zk session expiration events it is useful to have the id

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services