You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Francois Saint-Jacques (Jira)" <ji...@apache.org> on 2019/08/30 13:39:00 UTC
[jira] [Resolved] (ARROW-6387) [Archery] Errors with make
[ https://issues.apache.org/jira/browse/ARROW-6387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francois Saint-Jacques resolved ARROW-6387.
-------------------------------------------
Fix Version/s: 0.15.0
Resolution: Fixed
Issue resolved by pull request 5234
[https://github.com/apache/arrow/pull/5234]
> [Archery] Errors with make
> --------------------------
>
> Key: ARROW-6387
> URL: https://issues.apache.org/jira/browse/ARROW-6387
> Project: Apache Arrow
> Issue Type: Bug
> Components: Archery
> Reporter: Omer Ozarslan
> Assignee: Omer Ozarslan
> Priority: Minor
> Labels: pull-request-available
> Fix For: 0.15.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {{archery --debug benchmark run}} gives error on Debian 10, CMake 3.13.4, GNU make 4.2.1:
> {code:java}
> (.venv) omer@omer ~/src/ext/arrow/cpp/build master ● archery --debug benchmark run
> DEBUG:archery:Running benchmark WORKSPACE
> DEBUG:archery:Executing `['/usr/bin/cmake', '-GMake', '-DCMAKE_EXPORT_COMPILE_COMMANDS=ON', '-DCMAKE_BUILD_TYPE=release', '-DBUILD_WARNING_LEVEL=production', '-DARROW_BUILD_TESTS=ON', '-DARROW_BUILD_BENCHMARKS=ON', '-DARROW_PYTHON=OFF', '-DARROW_PARQUET=OFF', '-DARROW_GANDIVA=OFF', '-DARROW_PLASMA=OFF', '-DARROW_FLIGHT=OFF', '/home/omer/src/ext/arrow/cpp']`
> CMake Error: Could not create named generator Make
>
> Generators
> Unix Makefiles = Generates standard UNIX makefiles.
> Ninja = Generates build.ninja files.
> Watcom WMake = Generates Watcom WMake makefiles.
> CodeBlocks - Ninja = Generates CodeBlocks project files.
> CodeBlocks - Unix Makefiles = Generates CodeBlocks project files.
> CodeLite - Ninja = Generates CodeLite project files.
> CodeLite - Unix Makefiles = Generates CodeLite project files.
> Sublime Text 2 - Ninja = Generates Sublime Text 2 project files.
> Sublime Text 2 - Unix Makefiles
> = Generates Sublime Text 2 project files.
> Kate - Ninja = Generates Kate project files.
> Kate - Unix Makefiles = Generates Kate project files.
> Eclipse CDT4 - Ninja = Generates Eclipse CDT 4.0 project files.
> Eclipse CDT4 - Unix Makefiles= Generates Eclipse CDT 4.0 project files.
> Traceback (most recent call last):
> [[[cropped]]]{code}
> After trivial fix:
> {code:java}
> diff --git a/dev/archery/archery/utils/cmake.py b/dev/archery/archery/utils/cmake.py
> index 38aedab2d..3150ea9a6 100644
> --- a/dev/archery/archery/utils/cmake.py
> +++ b/dev/archery/archery/utils/cmake.py
> @@ -34,7 +34,7 @@ class CMake(Command):
> in the search path.
> """
> found_ninja = which("ninja")
> - return "Ninja" if found_ninja else "Make"
> + return "Ninja" if found_ninja else "Unix Makefiles"{code}
> I get another error:
> {code:java}
> [[[cropped]]
> -- Generating done
> -- Build files have been written to: /tmp/arrow-bench-48x_yleb/WORKSPACE/build
> DEBUG:archery:Executing `[None]`
> Traceback (most recent call last):
> File "/home/omer/src/ext/arrow/.venv/bin/archery", line 11, in <module>
> load_entry_point('archery', 'console_scripts', 'archery')()
> File "/home/omer/src/ext/arrow/.venv/lib/python3.7/site-packages/click/core.py", line 764, in __call__
> return self.main(*args, **kwargs)
> File "/home/omer/src/ext/arrow/.venv/lib/python3.7/site-packages/click/core.py", line 717, in main
> rv = self.invoke(ctx)
> File "/home/omer/src/ext/arrow/.venv/lib/python3.7/site-packages/click/core.py", line 1137, in invoke
> return _process_result(sub_ctx.command.invoke(sub_ctx))
> File "/home/omer/src/ext/arrow/.venv/lib/python3.7/site-packages/click/core.py", line 1137, in invoke
> return _process_result(sub_ctx.command.invoke(sub_ctx))
> File "/home/omer/src/ext/arrow/.venv/lib/python3.7/site-packages/click/core.py", line 956, in invoke
> return ctx.invoke(self.callback, **ctx.params)
> File "/home/omer/src/ext/arrow/.venv/lib/python3.7/site-packages/click/core.py", line 555, in invoke
> return callback(*args, **kwargs)
> File "/home/omer/src/ext/arrow/.venv/lib/python3.7/site-packages/click/decorators.py", line 17, in new_func
> return f(get_current_context(), *args, **kwargs)
> File "/home/omer/src/ext/arrow/dev/archery/archery/cli.py", line 270, in benchmark_run
> json.dump(runner_base, output, cls=JsonEncoder)
> File "/usr/lib/python3.7/json/__init__.py", line 179, in dump
> for chunk in iterable:
> File "/usr/lib/python3.7/json/encoder.py", line 438, in _iterencode
> o = _default(o)
> File "/home/omer/src/ext/arrow/dev/archery/archery/utils/codec.py", line 35, in default
> return BenchmarkRunnerCodec.encode(o)
> File "/home/omer/src/ext/arrow/dev/archery/archery/utils/codec.py", line 76, in encode
> return {"suites": [BenchmarkSuiteCodec.encode(s) for s in br.suites]}
> File "/home/omer/src/ext/arrow/dev/archery/archery/utils/codec.py", line 76, in <listcomp>
> return {"suites": [BenchmarkSuiteCodec.encode(s) for s in br.suites]}
> File "/home/omer/src/ext/arrow/dev/archery/archery/benchmark/runner.py", line 170, in suites
> suite_and_binaries = self.suites_binaries
> File "/home/omer/src/ext/arrow/dev/archery/archery/benchmark/runner.py", line 140, in suites_binaries
> self.build()
> File "/home/omer/src/ext/arrow/dev/archery/archery/utils/command.py", line 71, in __call__
> self.run(*argv, **kwargs)
> File "/home/omer/src/ext/arrow/dev/archery/archery/utils/cmake.py", line 154, in run
> super().run(*extra, *argv, **kwargs, cwd=self.build_dir)
> File "/home/omer/src/ext/arrow/dev/archery/archery/utils/command.py", line 68, in run
> return subprocess.run(invocation, **kwargs)
> File "/usr/lib/python3.7/subprocess.py", line 472, in run
> with Popen(*popenargs, **kwargs) as process:
> File "/usr/lib/python3.7/subprocess.py", line 775, in __init__
> restore_signals, start_new_session)
> File "/usr/lib/python3.7/subprocess.py", line 1436, in _execute_child
> executable = os.fsencode(executable)
> File "/home/omer/src/ext/arrow/.venv/lib/python3.7/os.py", line 809, in fsencode
> filename = fspath(filename) # Does type-checking of `filename`.
> TypeError: expected str, bytes or os.PathLike object, not NoneType {code}
> Everything ran smoothly after I installed ninja.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)