You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Szehon Ho <sz...@cloudera.com> on 2014/02/21 00:32:10 UTC

Review Request 18332: HIVE-6477: Aggregation functions for tiny/smallint broken with parquet

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18332/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-6477
    https://issues.apache.org/jira/browse/HIVE-6477


Repository: hive-git


Description
-------

Parquet uses ParquetByteInspector for tinyint.  During UDAF's, Hive uses reflection on the parquet inspector to find a 'corresponding' inspector (JavaByteObjectInspector), resulting in ClassCastException.  ParquetByteInspector needs to implement getPrimitiveJavaObject to return a byte, so that the corresponding inspector JavaObjectByteInspector can read it.

Similar issue exists for ParquetShortInspector, which is used for smallint.


Diffs
-----

  data/files/alltypesagg.txt PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/primitive/ParquetByteInspector.java d5d1bf1 
  ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/primitive/ParquetShortInspector.java 94f2813 
  ql/src/test/queries/clientpositive/parquet_agg.q PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_agg.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/18332/diff/


Testing
-------

Added a unit test for the same.


Thanks,

Szehon Ho