You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/09/05 20:26:37 UTC

Re: Review Request 22637: Restarting Hive MetaStore clears Hive client's stale config indicator

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22637/
-----------------------------------------------------------

(Updated Sept. 5, 2014, 6:26 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-6142
    https://issues.apache.org/jira/browse/AMBARI-6142


Repository: ambari


Description
-------

I changed Hive configs on a single node cluster. 4 components were correctly
shown as stale - needing restart. I went to the host page and I see that all
hive components (including hive-client) need restart. I restarted only the
_Hive Metastore_ component which incorrectly removed _Hive Client_ stale
indicator.

This is problematic because _Hive Client_ and _Hive Metastore_ use two
different config folders (/etc/hive/conf and /etc/hive/conf.server
respectively), and _Hive Client_ never updates its configs.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive.py 163304d 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py b0dc1f0 
  ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_client.py e6736e4 
  ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_metastore.py d5fd8aa 
  ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 0388cc6 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py 091e049 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 742a3e2 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 53f744d 
  ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 9bcf7df 

Diff: https://reviews.apache.org/r/22637/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 22637: Restarting Hive MetaStore clears Hive client's stale config indicator

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22637/#review52487
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Sept. 5, 2014, 6:26 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22637/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2014, 6:26 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-6142
>     https://issues.apache.org/jira/browse/AMBARI-6142
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> I changed Hive configs on a single node cluster. 4 components were correctly
> shown as stale - needing restart. I went to the host page and I see that all
> hive components (including hive-client) need restart. I restarted only the
> _Hive Metastore_ component which incorrectly removed _Hive Client_ stale
> indicator.
> 
> This is problematic because _Hive Client_ and _Hive Metastore_ use two
> different config folders (/etc/hive/conf and /etc/hive/conf.server
> respectively), and _Hive Client_ never updates its configs.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive.py 163304d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py b0dc1f0 
>   ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_client.py e6736e4 
>   ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_metastore.py d5fd8aa 
>   ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 0388cc6 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py 091e049 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 742a3e2 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 53f744d 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 9bcf7df 
> 
> Diff: https://reviews.apache.org/r/22637/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>