You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2022/07/20 21:06:13 UTC
svn commit: r1902894 - in /poi/trunk: poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
Author: fanningpj
Date: Wed Jul 20 21:06:13 2022
New Revision: 1902894
URL: http://svn.apache.org/viewvc?rev=1902894&view=rev
Log:
test issue
Modified:
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
poi/trunk/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
Modified: poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java?rev=1902894&r1=1902893&r2=1902894&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java (original)
+++ poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java Wed Jul 20 21:06:13 2022
@@ -1278,7 +1278,11 @@ public class XSSFSheet extends POIXMLDoc
@Deprecated
@Removal(version = "7.0.0")
public void setMargin(short margin, double size) {
- setMargin(PageMargin.getByShortValue(margin), size);
+ final PageMargin pageMargin = PageMargin.getByShortValue(margin);
+ if (pageMargin == null) {
+ throw new IllegalArgumentException( "Unknown margin constant: " + margin );
+ }
+ setMargin(pageMargin, size);
}
/**
@@ -1311,7 +1315,7 @@ public class XSSFSheet extends POIXMLDoc
case FOOTER:
pageMargins.setFooter(size);
break;
- default :
+ default:
throw new IllegalArgumentException( "Unknown margin constant: " + margin );
}
}
Modified: poi/trunk/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFSheet.java?rev=1902894&r1=1902893&r2=1902894&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFSheet.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFSheet.java Wed Jul 20 21:06:13 2022
@@ -1355,7 +1355,11 @@ public final class HSSFSheet implements
@Deprecated
@Removal(version = "7.0.0")
public void setMargin(short margin, double size) {
- setMargin(PageMargin.getByShortValue(margin), size);
+ final PageMargin pageMargin = PageMargin.getByShortValue(margin);
+ if (pageMargin == null) {
+ throw new IllegalArgumentException( "Unknown margin constant: " + margin );
+ }
+ setMargin(pageMargin, size);
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org