[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2824: [Load] Fix bug of wrong file group aggregation when handling broker load job

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on a change in pull request #2824: [Load] Fix bug of wrong file group aggregation when handling broker load job
URL: https://github.com/apache/incubator-doris/pull/2824#discussion_r373959142
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/load/BrokerFileGroupAggInfo.java
 ##########
 @@ -0,0 +1,239 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.load;
+
+import org.apache.doris.common.DdlException;
+import org.apache.doris.common.io.Writable;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Maps;
+import com.google.common.collect.Sets;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.io.DataInput;
+import java.io.DataOutput;
+import java.io.IOException;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+/*
+ * This class is mainly used to aggregate information of multiple DataDescriptors.
+ * When the table name and specified partitions in the two DataDescriptors are same,
+ * the BrokerFileGroup information corresponding to the two DataDescriptors will be aggregated together.
+ * eg1：
+ * 
+ *  DATA INFILE("hdfs://hdfs_host:hdfs_port/input/file1")
+ *  INTO TABLE `tbl1`
+ *  PARTITION (p1, p2)
+ * 
+ *  and
+ * 
+ *  DATA INFILE("hdfs://hdfs_host:hdfs_port/input/file2")
+ *  INTO TABLE `tbl1`
+ *  PARTITION (p1, p2)
+ *
+ *  will be aggregated together, because they have same table name and specified partitions
+ *  =>
+ *  FileGroupAggKey(tbl1, [p1, p2]) => List(file1, file2);
+ * 
+ * eg2:
+ * 
+ *  DATA INFILE("hdfs://hdfs_host:hdfs_port/input/file1")
+ *  INTO TABLE `tbl1`
+ *  PARTITION (p1)
+ * 
+ *  and
+ * 
+ *  DATA INFILE("hdfs://hdfs_host:hdfs_port/input/file2")
+ *  INTO TABLE `tbl1`
+ *  PARTITION (p2)
+ * 
+ *  will NOT be aggregated together, because they have same table name but different specified partitions
+ *  FileGroupAggKey(tbl1, [p1]) => List(file1);
+ *  FileGroupAggKey(tbl1, [p2]) => List(file2);
+ * 
+ * eg3:
+ * 
+ *  DATA INFILE("hdfs://hdfs_host:hdfs_port/input/file1")
+ *  INTO TABLE `tbl1`
+ *  PARTITION (p1, p2)
+ * 
+ *  and
+ * 
+ *  DATA INFILE("hdfs://hdfs_host:hdfs_port/input/file2")
+ *  INTO TABLE `tbl1`
+ *  PARTITION (p2, p3)
+ * 
+ *  will throw an Exception, because there is an overlap partition(p2) between 2 data descriptions. And we
+ *  currently not allow this. You can rewrite the data descriptions like this:
+ *  
+ *  DATA INFILE("hdfs://hdfs_host:hdfs_port/input/file1")
+ *  INTO TABLE `tbl1`
+ *  PARTITION (p1)
+ * 
+ *  and
+ * 
+ *  DATA INFILE("hdfs://hdfs_host:hdfs_port/input/file2")
+ *  INTO TABLE `tbl1`
+ *  PARTITION (p3) 
+ *  
+ *  and
+ * 
+ *  DATA INFILE("hdfs://hdfs_host:hdfs_port/input/file1")
+ *  INTO TABLE `tbl1`
+ *  PARTITION (p2) 
+ *  
+ *  and
+ *  
+ *  DATA INFILE("hdfs://hdfs_host:hdfs_port/input/file2")
+ *  INTO TABLE `tbl1`
+ *  PARTITION (p2)
+ *  
+ *  they will be aggregate like:
+ *  FileGroupAggKey(tbl1, [p1]) => List(file1);
+ *  FileGroupAggKey(tbl1, [p3]) => List(file2);
+ *  FileGroupAggKey(tbl1, [p2]) => List(file1, file2);
+ *  
+ *  Although this transformation can be done automatically by system, but it change the "max_filter_ratio".
+ *  So we have to let user decide what to do.
+ */
+public class BrokerFileGroupAggInfo implements Writable {
+    private static final Logger LOG = LogManager.getLogger(BrokerFileGroupAggInfo.class);
+
+    private Map<FileGroupAggKey, List<BrokerFileGroup>> aggKeyToFileGroups = Maps.newHashMap();
+    // auxiliary structure, tbl id -> set of partition ids.
+    // used to exam the overlapping partitions of same table.
+    private Map<Long, Set<Long>> tableIdToPartitioIds = Maps.newHashMap();
+
+    // this inner class This class is used to distinguish different combinations of table and partitions
+    public static class FileGroupAggKey {
+        private long tableId;
+        private Set<Long> partitionIds; // empty means partition is not specified
+
+        public FileGroupAggKey(long tableId, List<Long> partitionIds) {
+            this.tableId = tableId;
+            if (partitionIds != null) {
+                this.partitionIds = Sets.newHashSet(partitionIds);
+            } else {
+                this.partitionIds = Sets.newHashSet();
+            }
+        }
+
+        public long getTableId() {
+            return tableId;
+        }
+
+        public Set<Long> getPartitionIds() {
+            return partitionIds;
+        }
+
+        @Override
+        public boolean equals(Object obj) {
+            if (this == obj) {
+                return true;
+            }
+            if (!(obj instanceof FileGroupAggKey)) {
+                return false;
+            }
+
+            FileGroupAggKey other = (FileGroupAggKey) obj;
+            return other.tableId == this.tableId && other.partitionIds.equals(this.partitionIds);
+        }
+
+        @Override
+        public int hashCode() {
+            return Objects.hash(tableId, partitionIds);
+        }
+
+        @Override
+        public String toString() {
+            StringBuilder sb = new StringBuilder();
+            sb.append("[").append(tableId).append(": ").append(partitionIds).append("]");
+            return sb.toString();
+        }
+    }
+
+    public BrokerFileGroupAggInfo() {
 
 Review comment:
   It can be omitted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org