[GitHub] [skywalking] BFergerson commented on pull request #5085: Include request method type in rest mapping annotations

[GitBox <gi...@apache.org>]

BFergerson commented on pull request #5085:
URL: https://github.com/apache/skywalking/pull/5085#issuecomment-687053224


   @wu-sheng, I'm willing to fix this if I can run these tests necessary to confirm it works. However, I'm not even able to get the correct e2e tests to run successfully. These are the commands I'm using:
   ```sh
   git clone --recurse-submodules https://github.com/apache/skywalking.git
   cd skywalking/
   export SW_STORAGE=h2 && export SW_AGENT_JDK_VERSION=8 && export SKIP_TEST=true
   make docker && ES_VERSION=es7 TAG=latest-es7 make docker.oap
   cp -R dist test/e2e/
   ./mvnw --batch-mode -f test/e2e/pom.xml -am -DfailIfNoTests=false verify -Dit.test=org.apache.skywalking.e2e.profile.ProfileE2E
   ```
   
   The issue I get is the same as the one I stated above. Are you able to run those commands successfully? What am I doing wrong?
   
   Info:
   ```
   $ uname -a
   Linux brandon-XPS-15-7590 5.4.0-45-generic #49-Ubuntu SMP Wed Aug 26 13:38:52 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
   
   $ docker -v
   Docker version 19.03.8, build afacb8b7f0
   
   $ java -version
   openjdk version "1.8.0_265"
   OpenJDK Runtime Environment (build 1.8.0_265-8u265-b01-0ubuntu2~20.04-b01)
   OpenJDK 64-Bit Server VM (build 25.265-b01, mixed mode)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org